coreui / coreui-pro / 34994834511

94%

push

github

fix(Autocomplete): default options to an empty array (#1319)

The default for `options` was `false` while the type map expected
`(array|null)`, so `new Autocomplete(el)` without a config threw a
TypeError. The same throw escaped the `window.load` loop that
initializes every `[data-coreui-toggle="autocomplete"]` on the page, so
one picker without `data-coreui-options` left all the ones after it
uninitialized.

`_getOptionsFromConfig()` already maps every falsy value to `[]`, so
nothing below the config changes and `options: null` still passes. The
type map now also names the comma-separated string that
`_configAfterMerge` accepts, the way `search` already does for the same
conversion.

The docs page carried the same defect a second time: the first
data-attribute snippet used `data-coreui-search="true"`, and a boolean is
not in `(array|string|null)` either, so that snippet broke the same loop.
It now uses `global` and carries options, so it shows a picker that
actually opens. The sentence above it described a class and an input that
the plugin creates itself, and the JavaScript example initialized by hand
markup that the data API had already initialized. The disabled example
dropped an empty `data-coreui-options`, which only ever existed to get
past the old default. The API table gets the input `options` and
`searchNoResultsLabel` really accept, and the `searchNoResultsLabel` type
now reads like every other entry in the map.

4003 of 4413 branches covered (90.71%)

Branch coverage included in aggregate %.

7338 of 7618 relevant lines covered (96.32%)

704.74 hits per line