coreui / coreui-pro / 34997337552

94%

push

github

fix(MultiSelect): keep the search text out of the form data (#1321)

The field that filters the option list carried a `name` built from the
component's own name, and a plain input is serialized, so every form
holding a multi select submitted a `search-<name>` key with whatever the
user typed into the filter. Here it needed no configuration at all:
`_uniqueName` falls back to the host `<select>`'s own name, so a plain
`<select name="tech">` in a form was enough to send `search-tech`.

The field also had no `autocomplete`, which the React, Vue and Angular
editions all set, so with the name gone it would have been an unnamed
input the browser still offers to autofill. It now says `off` like the
others, written the way the v6 file writes it so the two lines match.

The `id` stays; an id is not serialized, and nothing reads that one.

4003 of 4413 branches covered (90.71%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

7338 of 7618 relevant lines covered (96.32%)

704.9 hits per line