coreui / coreui-pro / 34979475120

94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(DatePicker, DateRangePicker): let the time selection drop minutes and seconds (#1311)

* feat(DatePicker, DateRangePicker): let the time selection drop minutes and seconds

The pickers built their inline time selection from a fixed config, so it always
offered hours, minutes and seconds and nothing could change that. `hours`,
`minutes` and `seconds` are now picker options, forwarded to both time pickers
so a range keeps its start and end in step.

Formatting and parsing read the same units. `getTimeFormatOptions` turns the
configuration into one Intl time bag that `_formatDate` writes with and that
`_parseDate` builds its pattern from, so a value the picker wrote is a value it
can read back: with `seconds: false` a date reads `6/15/2023, 2:30 PM` and
parses in any locale, where before only the full locale format matched and
anything shorter fell through to `Date.parse`, which understands English alone.

Seconds need minutes. Asking Intl for hours and seconds without minutes matches
no pattern and it answers with its debug rendering, `6/15/2023, 2 PM
(second: 45)`, so `minutes: false` drops seconds from the selection and from the
value.

* chore: raise three JS size budgets for the date picker time options

The time options and the shared format helper cost 0.60 kB on the bundle and
0.15 kB on the minified ESM build. The three ceilings they cross stood 10-30
bytes above the current size, so they had stopped measuring regressions; the new
ones leave ~0.25 kB.

Coverage Stats

4003 of 4413 branches covered (90.71%)

Branch coverage included in aggregate %.

15 of 16 new or added lines in 2 files covered. (93.75%)

1 existing line in 1 file now uncovered.

7336 of 7618 relevant lines covered (96.3%)

704.45 hits per line