coreui / coreui-pro / 34967575818

96%

main: 94%

push

github

fix(Autocomplete): default options to an empty array (#1309)

* fix(Autocomplete): default `options` to an empty array

`Default.options` was `false` while `DefaultType.options` said `(array|null)`,
so the component's own default failed its own type check. `new
Autocomplete(element)` with no config threw `Option "options" provided type
"boolean" but expected type "(array|null)"`. The same throw hit the
`window.load` data-api scan on the first `[data-coreui-autocomplete]` carrying
no `data-coreui-options`, which is the markup the docs show for JS init. It
escaped the loop, so every autocomplete after it on the page stayed
uninitialized.

`_getOptionsFromConfig()` already maps any falsy value to `[]`, so nothing
downstream changes and `options: null` stays accepted.

The "Via data attributes" snippet broke the same way: `data-coreui-search="true"`
becomes a boolean in `normalizeData`, which `DefaultType.search`
(`(array|string|null)`) rejects, so the first snippet on the page threw and
killed the same scan. It now passes `global`, the value the JavaScript example
below it already uses.

The API table listed `options` as `boolean, array` / `false`, a value that
throws when passed explicitly, and omitted the comma-separated string that
`_configAfterMerge` splits and most examples on the page rely on.
`searchNoResultsLabel` was listed as `string` although it defaults to `false`,
and its rule carried a stray pair of parentheses.

The data-api test built an instance by hand and asserted `getInstance`, so it
never reached the `load` listener. It now dispatches the event over an element
with options and one without, and a second test loads the documented
data-attribute markup.

* chore: check every default value against its own DefaultType rule

The script compared the two maps key by key, so a `Default` value that could
never pass its own `DefaultType` rule went unnoticed until someone constructed
the component without a config. It now also reads each literal... (continued)

5679 of 6323 branches covered (89.81%)

Branch coverage included in aggregate %.

10965 of 11367 relevant lines covered (96.46%)

472.22 hits per line