coreui / coreui-pro / 34970833214

96%

main: 94%

push

github

fix(Autocomplete): remove the markup dispose generated in the host (#1310)

`dispose()` tore down the floating layer, the list box and the listeners and
removed the panel, but left everything `_createAutocomplete()` had built inside
the host: the `.form-control` input, the `.autocomplete-input-hint` input, the
cleaner and picker buttons, plus the classes it put on the host and the
`tabindex` it set. Every dispose and re-init cycle appended another set of
controls, so a page that tears the component down and rebuilds it, on a route
change or a re-render, accumulated one more each time.

The generated nodes now go with their listeners, and the host gets back the
shape it had at construction. The component records the classes it actually
added, so `autocomplete`, `disabled` and `form-control-group` come off only
when they were not already there and a page keeps its own; `is-invalid`,
`is-valid` and `show` are removed outright, because construction sets those
from the config and clears them when the config says otherwise. `tabindex` goes
back to the value the host carried, rather than staying at the `-1` the
component writes, so a tab stop the page wrote survives.

`dispose()` is idempotent again: it reads the host for the restore, and
`super.dispose()` nulls that reference, so a second call returned through the
guard instead of throwing.

`applyControlGroupClasses()` silences the transition for one frame by writing
`style.transitionProperty` and restoring it, which left an empty `style`
attribute on a host that had none. It now removes the attribute it created,
for every component that builds its own frame.

`_getClassNames()` read the host's own classes and added them back to the same
host, so the loop it fed could not change anything. Both are gone, along with
the test that only asserted the getter echoed the element.

5690 of 6335 branches covered (89.82%)

Branch coverage included in aggregate %.

25 of 25 new or added lines in 2 files covered. (100.0%)

10982 of 11384 relevant lines covered (96.47%)

473.47 hits per line