coreui / coreui-pro / 34896780147

96%

main: 94%

push

github

fix(RTL)!: mirror on the element's own direction, not on an ancestor (#1301)

`rtl()` emitted `*[dir="rtl"] &`, which asks whether any ancestor is
right-to-left. Every logical property it is paired with asks something else:
what direction this element is in. The two answers differ whenever a subtree,
or the element itself, carries its own `dir`, and then the mirrored value lands
on an unmirrored layout. Both mixins now test the element, `&:dir(rtl)` and
`&:dir(ltr)`, which is the same question the logical properties answer. The
toaster's `rtl-self()`, added for that reason a few hours earlier, is gone
again: `rtl()` does it.

Six rules could not take the test on their own selector, because a pseudo-class
cannot follow a pseudo-element and browsers drop the whole rule when it does.
The breadcrumb divider, the submenu caret and the sidebar togglers move it to
the element the direction belongs to through a new `rtl-nested()`, which keeps
the build flags `bidi()` honours: in an RTL-only build the mirrored block still
stands in for the base, measured identical to the old output in Chromium for
`$enable-ltr: false` and for both flags off.

Measured in Chromium in four nestings of `dir`, before and after. A closed
`.offcanvas-start` and `.drawer-start` inside a `dir="ltr"` island of a
right-to-left page used to sit in the middle of the viewport at 400..800 px
instead of hiding past the edge they are pinned to, and the same happened to
every panel whose element carried its own `dir`; `.badge-position-top-start`
missed its corner by 26 px and `.translate-middle` by 40 px. All sixteen
combinations are correct now, and a plain left-to-right or right-to-left
document is untouched: `coreui.css` differs by 54 lines carrying 59 selectors,
`coreui-utilities.css` by two, and nothing else moves in either file.

The new visual spec holds the panels, the badge, the utility, the breadcrumb
divider, the submenu caret and the sidebar toggler in all four nestings; it
fails o... (continued)

5661 of 6315 branches covered (89.64%)

Branch coverage included in aggregate %.

10954 of 11361 relevant lines covered (96.42%)

470.35 hits per line