coreui / coreui-pro / 34890220449

96%

main: 94%

push

github

fix(Toaster)!: logical entry edges, and centers that leave the way they came (#1300)

`enter` and `leave` take `start` and `end` again, and now mean it. The inline
offsets are multiplied by `--cui-toast-inline-sign`, which the container flips
to `-1` under `:dir(rtl)`, so a side named in the options follows the direction
the container sits in, exactly like the placement class it belongs to. The six
inline placement classes read the same sign, which replaces the pair of
mirrored rules they carried.

The three `center` placements stop mixing axes. `top-center` and
`bottom-center` dropped a toast in from the edge and then slid it out
sideways; they now send it back out the edge it came from. `middle-center`
stands in the middle of the screen with no edge to come from, so its toasts
only fade, in and out. `leave` therefore takes `top` and `bottom` as well,
since an exit along the block axis is now a real one, and `leave: 'auto'`
follows `enter` rather than the placement, so an explicit entry edge is the
exit edge too.

Measured in Chromium, the direction a toast travels in the first frame and in
the last: `top-center` in from above and out upwards, `bottom-center` in from
below and out downwards, `middle-center` neither, and `top-start` in from the
left in a left-to-right document against the right in a right-to-left one. A
toast leaving a center column now crosses the one next to it, 17 px of a 47 px
toast at opacity 0.35, and it crosses behind it: the newest toast keeps the
highest stacking order, which the spec now holds along with all nine
placements in both directions, the exit along the entry edge, and an explicit
`start` edge in four nestings of `dir`.

Both options are validated with `Object.hasOwn`, so an inherited key such as
`toString` is rejected instead of writing a function into the translate.

The sign in the edge values costs ten bytes over the `coreui.bundle.js`
ceiling, so it goes up by half a kilobyte, and `coreui.esm.js` with it: it sa... (continued)

5661 of 6315 branches covered (89.64%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

10954 of 11361 relevant lines covered (96.42%)

470.34 hits per line