coreui / coreui-pro / 34845395672

94%

push

github

fix(Calendar): keep ISO week numbers correct for years below 100 (#1289)

`getISOWeekNumberAndYear` built the reference date for week 1 with
`new Date(tempDate.getFullYear(), 0, 4)`. That constructor maps years 0–99 onto
1900–1999, so the distance it measured spanned nineteen centuries: a date in
year 99 reported week -99135 instead of 3. Copying the date and moving it with
`setMonth(0, 4)` keeps the full year.

Reachable through the calendar's week numbers and week formatting for any date
carrying a year below 100. Modern years are unaffected — the existing specs pin
2023 week 23 and the 2023-01-01 rollover, and both still pass.

`getMondayOfISOWeek1` builds a date the same way and is deliberately left alone:
its three call sites all run the year through `parseYearSmart`, which widens
anything below 100 to four digits, so the trap is unreachable there.

The React and Vue ports carry a comment on the replaced line. It is omitted here
because `dist/js/coreui.js` has about 20 bytes of gzip headroom under its
bundlewatch ceiling and the comment costs roughly 60.

3969 of 4388 branches covered (90.45%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

7320 of 7604 relevant lines covered (96.27%)

694.92 hits per line