coreui / coreui-pro / 34850984383

94%

push

github

fix(MultiSelect, Autocomplete, OTPInput): disabled options, single mode without search, deleted digits (#1291)

MultiSelect threw a TypeError when an option was picked in single mode with
`search` off, because the handler cleared a search field that is never created.

Disabled options in MultiSelect and Autocomplete carried `tabindex="0"` and were
activated by click, Enter or Space; only the pointer was blocked, and only by
CSS. They now get `tabindex="-1"`, the activation path returns early, and
MultiSelect announces them with `aria-disabled`.

OTPInput marked every slot `required` regardless of the option, because a
boolean was tested against `null`; it now follows the option and leaves a
`required` written in the markup alone.

Deleting a digit left the stale value in the hidden input, so the form submitted
the deleted character and no `change` fired. A character the mask rejects had
the same effect. Both recompute the hidden value now, exactly once per edit, and
the first slot goes back to holding a whole code once the field is emptied, so
SMS autofill works again after the user wipes what they typed.

The bundlewatch ceiling for `dist/js/coreui.js` moves from 98 to 99 kB: `main`
was already 10 bytes under it.

3981 of 4398 branches covered (90.52%)

Branch coverage included in aggregate %.

18 of 19 new or added lines in 3 files covered. (94.74%)

7323 of 7607 relevant lines covered (96.27%)

695.48 hits per line