IJHack / QtPass / 34776298671

93%

Build Type

push

github

Committed by web-flow

Commit Message

fix: toolbar stays in the old theme after a KDE light/dark switch (#1669)

* fix: toolbar no longer stays in the old theme after a KDE light/dark switch

After #1661 the content pane and field frames follow a runtime theme
switch, but on KDE the toolbar still did not: dark bar with dark icons on
a light window, or the reverse.

Diagnosed with an instrumented build on Plasma 6 / Breeze: the app
palette, icons and every other widget switch; only ui->toolBar keeps a
palette Breeze imposed. Breeze's ToolsAreaManager gives top toolbars a
"header" palette and re-applies it on every ApplicationPaletteChange and
on re-polish, computing the header colours from a KSharedConfig of
kdeglobals that is not reparsed in this process — so it keeps stamping
the previous theme's colours back on. A plain Qt probe app happened to
get a fresh config; QtPass does not, and re-polishing does not help.

Fix in MainWindow: filter PaletteChange on the toolbar and, deferred by a
zero timer, compare the lightness of the toolbar's Window colour with the
application palette. A real header tint is within a few units of the
window colour; the other theme is >64 apart. In that case the imposed
palette is cleared so the toolbar follows the application palette (and
any later stale re-apply is caught the same way).

Tests: toolBarDropsStaleStylePaletteAfterThemeSwitch simulates Breeze
(property + dark palette on a light app) and expects the reset — red on
main; toolBarKeepsHeaderTintInSameTheme checks a same-theme tint is left
alone. tst_mainwindow 21/21.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* fix: paint the toolbar background ourselves once the stale palette is dropped

Breeze also fills the main window's tools-area rectangle from the same
stale header palette, and QToolBar is transparent by default, so clearing
the palette alone changed nothing on screen (only in QWidget::grab()).
Verified with an... (continued)

Coverage Stats

10 of 10 new or added lines in 1 file covered. (100.0%)

28 existing lines in 2 files now uncovered.

4658 of 7227 relevant lines covered (64.45%)

58.15 hits per line