IJHack / QtPass / 34769437996

93%

Build Type

push

github

Committed by web-flow

Commit Message

test: isolate QtPassSettings from the user's live config (#1662)

* test: isolate QtPassSettings from the user's live config

Seven suites wrote to ~/.config/IJHack/QtPass.conf (or the registry) and
each carried its own backup/restore code: saved members restored in
cleanupTestCase(), a portable-mode file copy in tst_settings, resets of
leftover values in initTestCase(). None of that survives a suite that is
killed half-way; a temp store path then stays in the real config.

tests/auto/testsettings.h provides isolateTestSettings(): redirects
QSettings (NativeFormat and IniFormat, user and system scope) into a
process-lifetime QTemporaryDir, switches the default format to ini so
Windows does not fall back to the registry, and enables QStandardPaths
test mode. Every suite that touches settings calls it first thing in
initTestCase(), and the per-suite backup/restore code is gone. Per-test
guards that keep tests independent of each other are untouched.

Verified: all seven suites green, md5 of the live QtPass.conf identical
before and after the run, nothing written under ~/.qttest.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* test: abort when the isolated settings dir cannot be created; normalise paths

An invalid QTemporaryDir has an empty path(), and QSettings::setPath()
would turn that into "/". Fail loudly instead. Paths go through
QDir::cleanPath() per repo convention.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* settings: construct QtPassSettings with QSettings::defaultFormat()

QSettings(organization, application) always uses NativeFormat and
ignores setDefaultFormat(). On Windows NativeFormat is the registry and
QSettings::setPath() cannot redirect it, so the test isolation would
still have written to HKEY_CURRENT_USER there. The explicit-format
constructor with defaultFormat() kee... (continued)

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

22 existing lines in 6 files now uncovered.

4648 of 7216 relevant lines covered (64.41%)

85.97 hits per line