IJHack / QtPass / 34769290376

93%

push

github

fix: follow light/dark theme switches at runtime (#1661)

* fix: follow the desktop theme when it switches between light and dark at runtime

KDE (and GNOME/macOS) flip the application palette in the evening and
morning. Two parts of the main window kept the previous theme:

1. The content browser (ui->textBrowser) carried a stylesheet
   "background: palette(base)". QStyleSheetStyle resolves palette()
   references once when it polishes the widget and does not repolish on
   a palette change, so the browser stayed black after a switch to light
   (or white after a switch to dark). A QTextBrowser paints Base natively;
   the stylesheet added nothing. Removed. The context-menu reparent
   workaround that this stylesheet had made necessary stays, with its
   comment updated.

2. PasswordDisplayPanel bakes QPalette::Mid into the field-frame border
   stylesheet at creation time, so an entry already on screen kept the
   old border colour. The style is now applied by applyFrameStyle() and
   re-derived by refreshPalette(), which MainWindow::changeEvent() calls
   on QEvent::PaletteChange. (Top-level widgets receive PaletteChange for
   an application-wide switch; ApplicationPaletteChange is delivered to
   the QApplication object.)

Tests (tst_mainwindow):
- textBrowserFollowsRuntimePaletteChange: swaps the application Base
  colour twice after the window is shown and checks the grabbed pixel.
  Fails on the old code with the browser frozen at its polish-time
  colour.
- fieldFrameBorderFollowsRuntimePaletteChange: displays an entry, changes
  QPalette::Mid, asserts the frame stylesheet carries the new colour.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* test(mainwindow): compare browser lightness, not exact pixel colour

Qt 5.15's Fusion style renders Base #101010 as #070c10 under the
offscreen platform, so the exact QCOMPARE failed on the 5.15 CI job.
Lightness threshol... (continued)

13 of 13 new or added lines in 2 files covered. (100.0%)

4649 of 7214 relevant lines covered (64.44%)

71.31 hits per line