IJHack / QtPass / 34763407422

93%

Build Type

push

github

Committed by web-flow

Commit Message

fix: report a qrencode binary that cannot start instead of an empty QR popup (#1659)

* fix: report a qrencode binary that cannot start instead of showing an empty QR popup

When the configured qrencode executable does not exist, QProcess never
starts: exitStatus() stays NormalExit and exitCode() 0, so the old
`exitStatus() || exitCode()` check took the success branch and opened a
dialog with a null pixmap. Now waitForStarted() failure shows
"Could not start qrencode: <path>" in the status bar and returns.

The exit check is also split: exitCode() is only consulted when the
process did not crash (it is undefined after CrashExit), and an empty
stderr gets a fallback message instead of a blank status line.

Test: tst_mainwindow::showTextAsQRCodeReportsMissingQrencode drives the
production path via PasswordDisplayPanel::qrRequested with a bogus
qrencodeExecutable and asserts the status message names it. Fails on
the old code with an empty status message.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* test(mainwindow): restore qrencodeExecutable in cleanupTestCase

The suite writes the user's live config; the new QR test left a bogus
path behind.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* fix: bail out when qrencode does not finish within the wait timeout

waitForFinished() returning false leaves exitStatus()/exitCode() at
their defaults, which would again reach the empty-dialog path.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

4 of 14 new or added lines in 1 file covered. (28.57%)

2 existing lines in 1 file now uncovered.

4637 of 7205 relevant lines covered (64.36%)

70.68 hits per line