coreui / coreui-pro / 34725896850

95%

main: 94%

push

github

fix(Popup)!: the panel is the dialog, and the field stays out of its focus cycle (#1260)

The trap held the field and carried the panel alongside it, so Tab cycled
between the two. That is neither of the patterns a date control can follow:
a dialog traps Tab inside itself, and a combobox leaves focus in the field
and drives the list through aria-activedescendant. These pickers already
chose the dialog — focus moves into the panel on open and Escape hands it
back — so the panel is what the trap holds now, and the field, which sits
outside it, is out of the cycle.

The panel says so too. The toggle has been promising aria-haspopup="dialog"
while the panel carried no role at all; it is now role="dialog" with
aria-modal, and only while it is trapped.

Dismissal moves from click to pointerdown. The trap answers focusin, so
closing on click was always too late: the browser moved focus onto whatever
was pressed, the trap took it straight back, and pressing another field
left the caret in the picker. Closing on the press frees the focus first.

Measured in Chromium, focus after each way out of an open panel:

  press another input   the input        (was: back in the picker)
  press a button        the button       (was: back in the picker)
  Tab / Shift+Tab       inside the panel (unchanged)
  Escape                the field        (unchanged)

Date Picker asserts both halves in the WCAG gate: Tab stays in the panel,
and picking a day hands focus back to the field. The keyboard tables of
Date Picker and Time Picker promised the old cycling and no longer do.

5614 of 6265 branches covered (89.61%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

10887 of 11290 relevant lines covered (96.43%)

458.73 hits per line