coreui / coreui-pro / 34721543416
95%
main: 94%

LAST BUILD BRANCH: v6-dev
DEFAULT BRANCH: main
Ran
Jobs 1
Files 76
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.994% (+0.004%) from 93.99%
34721543416

push

github

web-flow 
fix(Popup): hand focus back to a node that still exists (#1259)

The panel remembered the element that had focus when it opened and focused
that same node on close. A date field rebuilds its sections as the value
lands, so by then the remembered node was detached, focus() on it did
nothing, and a keyboard user who picked a day was left on <body> — no focus
ring, and a screen reader with no place in the document. The date picker
page promises the field gets focus back.

The target is now resolved on close: the remembered node when it is still
connected, otherwise the first focusable inside the anchor, which outlives
any rebuild of the field.

Focus is only handed back when the panel still holds it. Focus already
parked on the anchor was put there by something that ran after the panel
lost it — the toggle the user clicked, or the trap reacting to a click
outside — and moving it again would override that.

Date Picker asserts focus order in the WCAG gate now: open with the
keyboard, pick a day, and the focus has to land back in the picker.
Reverting the fix above fails that assertion.

React and Vue do not share the defect. Their fields are reconciled rather
than rebuilt, so the node survives the value change — measured, both keep
the same element object and it stays connected.

5612 of 6263 branches covered (89.61%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

10884 of 11287 relevant lines covered (96.43%)

458.62 hits per line

Jobs
ID Job ID Ran Files Coverage
1 34721543416.1 76
93.99
 GitHub Action Run
Source Files on build 34721543416