coreui / coreui-pro / 34762108551

95%

main: 94%

push

github

refactor(SectionInput, DateRangeInput)!: one prop per section text, not two bags (#1261)

* refactor(SectionInput, DateRangeInput)!: one prop per section text, not two bags

placeholders and sectionLabels were collective objects keyed by section type,
the shape the project rule forbids for text and a11y names. They are public,
documented options on four date and time field components and reach four more
through the pickers, so the rename stops being possible the day the alpha
ships.

Each section now has its own pair: ariaDayLabel through ariaMeridiemLabel
carry the label text as their default, and dayPlaceholder through
meridiemPlaceholder replace the mask characters. The API table gains
eighteen rows with a default on each, and one label can be replaced without
restating the rest of the object.

The placeholder props default to null on purpose. The resolution chain runs
configured, then the section's own placeholder, then the default clipped to
the section length, and a real default here would skip the last two steps.

* docs(forms): the option tables go back to alphabetical after the new rows

* chore(bundlewatch): room for the flat section text props

Eighteen prop names with their defaults replace two object options, which
costs about 0.1 kB gzipped in each entrypoint and put five of them a
fraction over. Measured after the change: 147.09 against 147, 136.14
against 136, 100.05 against 100, 137.09 against 137, 90.62 against 90.5.

Raised by half a kilobyte each rather than to the new figure, so the next
change does not trip the wire on someone else's behalf. The v6 size pass
comes at the end; this is one of the entries it will read.

5613 of 6263 branches covered (89.62%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

10887 of 11290 relevant lines covered (96.43%)

466.74 hits per line