coreui / coreui-pro / 32573460432

93%

main: 94%

push

github

build(css): minify with lightningcss, not clean-css (#845)

clean-css does not know `@starting-style`. It drops the block and then
mis-parses the orphaned brace:

    WARNING: Invalid property name '@starting-style { opacity'. Ignoring.
    WARNING: Unexpected '}' at probe.css:11:0.

Run over the current compiled stylesheet it keeps 1 of the 10
`@starting-style` blocks and none of the `@supports not (interpolate-size)`
fallback, and warns about `@layer helpers` on the way. So every entry
animation that needs an enter-from state — toast, menu, dialog, drawer — was
missing it in the file we ship for production, and the collapse fallback for
browsers without `interpolate-size` never reached it at all, while the
expanded build was correct. The mis-parse also hoisted a `@supports` block out
of `@layer components`, where unlayered author styles beat every layer.

`build/css-minify.mjs` is adapted from Bootstrap's script of the same name,
`Features.LightDark` exclusion included: lowering `light-dark()` rewrites it
into a pair of custom properties resolved by a media query, which cannot see
`data-coreui-theme`, so a forced theme would follow the system instead. Ours
recurses into `dist/css/themes/`, imports browserslist statically, and logs
one line per file.

After: 10 of 10 `@starting-style` blocks and the `@supports not` fallback
survive, both `@supports` blocks stay inside their layer, and `light-dark()`
comes through untouched.

Budgets are retuned to the new minifier rather than raised for a feature.
lightningcss keeps longhands where clean-css merged them into shorthands, so
`coreui.min.css` goes 53.01 → 59.21 kB gzip on the same source; the other
three files get smaller and their ceilings come down: grid 6.75 → 6.5,
reboot 5.25 → 5, utilities 15.5 → 15.

4533 of 5098 branches covered (88.92%)

Branch coverage included in aggregate %.

8652 of 9053 relevant lines covered (95.57%)

400.16 hits per line