coreui / coreui-pro / 32569875643

93%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(Collapse)!: CSS owns the animation, JavaScript measures only as a fallback (#843)

* refactor(Accordion): move the size animator and its probe to a shared util

The `interpolate-size` capability probe and the measured-size choreography
(disable the transition, plant the start size, reflow, hand the timing back to
the stylesheet) lived inside the accordion. The collapse needs both for the
same fallback, so they move to js/src/util/size-transition.ts unchanged; the
accordion keeps its own marker attribute and cleanup order. 29/29 accordion
specs pass untouched.

* feat(Collapse)!: CSS owns the animation, JavaScript measures only as a fallback

Where `interpolate-size: allow-keywords` is supported the stylesheet animates
the size to the `auto` of the open state itself: `display` transitions
discretely with `allow-discrete`, `@starting-style` supplies the enter-from
size, and JavaScript only toggles classes. Everywhere else JavaScript measures
the two sizes through the shared size-transition util and the stylesheet still
times the move — the same fallback shape the accordion ships.

Class choreography changes on both paths and is now identical between them:
`.collapse` never leaves the element, `.show` toggles at the start of both
directions, `.collapsing` marks a running transition. The `@starting-style`
block is scoped to `.show.collapsing`, so a collapse that loads already open
does not play an entrance. An open `.collapse-horizontal` is `fit-content`
wide: the open size is the animation's target, and a target of `auto` spent
most of the run growing an empty box past the content — this also removes the
end-of-animation jump to container width the measured animation made.

Two defects surfaced and are fixed here:

- `SELECTOR_ACTIVES` carried a `.collapse.collapsing` arm that could never
  match (the old choreography removed `.collapse` mid-run). With both classes
  present it came alive and an accordion parent refused to open the second
  panel of... (continued)

Coverage Stats

4533 of 5098 branches covered (88.92%)

Branch coverage included in aggregate %.

33 of 36 new or added lines in 4 files covered. (91.67%)

4 existing lines in 2 files now uncovered.

8652 of 9053 relevant lines covered (95.57%)

400.11 hits per line