sgobotta / live_dj / ee159b62d161b5561f952d3af6a9f78e0cdae62a
68%

DEFAULT BRANCH: dev
Ran
Jobs 1
Files 82
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.834% (+0.8%) from 66.014%
ee159b62d161b5561f952d3af6a9f78e0cdae62a

push

github

web-flow 
Add a tabbed room settings modal (General/Security) (#133)

* Add a tabbed room settings modal with General and Security tabs

Replaces the standalone room-password modal with a settings modal
opened from a new header gear icon (or the ; shortcut), reusing the
existing <.modal> component and route-per-modal-state pattern. The
Security tab absorbs the previous password UI unchanged; the new
General tab lets a user rename the room via Sessions.update_room_name/2,
which broadcasts room_name_changed so other viewers stay in sync.

* Rename settings_tab to modal_tab and flag it as a reuse candidate

Signals the extraction point for a future tabbed_modal/modal_tab pair
once a second tabbed modal exists, without building that abstraction
for a single caller.

* Keep the settings modal open after saving name or password

Saving now patches back to the same tab route instead of the plain
room route, so a successful save shows its flash without closing the
modal.

* Give the settings modal tighter, alignment-matched padding

Adds optional content_class/close_button_class attrs to the shared
<.modal> component, defaulting to its current p-5/top-6 right-5
layout so every other modal is unaffected. The settings modal opts
into a smaller top padding and moves the close button up to match
the tab row, and drops its now-redundant header title.

* Fix keybindings.js key ordering for eslint sort-keys

1330 of 1990 relevant lines covered (66.83%)

26.94 hits per line

Coverage Regressions

Lines Coverage ∆ File
43
46.94
 5.89% //lib/livedj_web/live/sessions/room_live/show.ex
18
83.51
 0.17% //lib/livedj_web/components/core_components.ex
14
50.0
 14.29% //lib/livedj_web/components/session_modals.ex
9
80.0
 0.83% //lib/livedj/sessions/channels.ex
1
41.24
 2.65% //lib/livedj/sessions.ex
1
94.12
 0.37% //lib/livedj/sessions/room.ex
1
82.76
 -2.43% //lib/livedj_web/router.ex
Jobs
ID Job ID Ran Files Coverage
1 ee159b62d161b5561f952d3af6a9f78e0cdae62a.1 82
66.83
 GitHub Action Run
Source Files on build ee159b62d161b5561f952d3af6a9f78e0cdae62a