sgobotta / live_dj / e61a616da8a715263cecece197f34229417a1eeb
68%

DEFAULT BRANCH: dev
Ran
Jobs 1
Files 82
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.784% (-0.05%) from 66.834%
e61a616da8a715263cecece197f34229417a1eeb

push

github

web-flow 
Standardize keyboard focus rings across interactive elements (#134)

* Add a tabbed room settings modal with General and Security tabs

Replaces the standalone room-password modal with a settings modal
opened from a new header gear icon (or the ; shortcut), reusing the
existing <.modal> component and route-per-modal-state pattern. The
Security tab absorbs the previous password UI unchanged; the new
General tab lets a user rename the room via Sessions.update_room_name/2,
which broadcasts room_name_changed so other viewers stay in sync.

* Rename settings_tab to modal_tab and flag it as a reuse candidate

Signals the extraction point for a future tabbed_modal/modal_tab pair
once a second tabbed modal exists, without building that abstraction
for a single caller.

* Keep the settings modal open after saving name or password

Saving now patches back to the same tab route instead of the plain
room route, so a successful save shows its flash without closing the
modal.

* Give the settings modal tighter, alignment-matched padding

Adds optional content_class/close_button_class attrs to the shared
<.modal> component, defaulting to its current p-5/top-6 right-5
layout so every other modal is unaffected. The settings modal opts
into a smaller top padding and moves the close button up to match
the tab row, and drops its now-redundant header title.

* Fix keybindings.js key ordering for eslint sort-keys

* Standardize keyboard focus rings on the brand-violet pattern

Applies the existing focus-visible:ring-brand + offset convention
(already used in custom_components.ex) to <.button>, <.modal>'s close
button, all input/1 variants, modal_tab, the settings modal's raw
inputs, and the header icon buttons. Using focus-visible instead of
focus means the ring only appears for keyboard navigation, not mouse
clicks, and outline-none suppresses the browser's default blue
outline that was showing through everywhere.

* Extend brand focus rings to remaining interactive contr... (continued)

1329 of 1990 relevant lines covered (66.78%)

26.95 hits per line

Coverage Regressions

Lines Coverage ∆ File
25
50.0
 0.0% //lib/livedj_web/components/session_modals.ex
24
83.51
 0.0% //lib/livedj_web/components/core_components.ex
6
64.52
 0.0% //lib/livedj_web/live/components/player_controls/volume_control_component.ex
2
63.64
 -3.03% //lib/livedj_web/live/player_controls_live.ex
1
87.5
 0.0% //lib/livedj_web/live/components/player_controls/fullscreen_control_component.ex
Jobs
ID Job ID Ran Files Coverage
1 e61a616da8a715263cecece197f34229417a1eeb.1 82
66.78
 GitHub Action Run
Source Files on build e61a616da8a715263cecece197f34229417a1eeb