sgobotta / live_dj

68%

dev: 68%

LAST BUILD ON BRANCH feature/move-theme-to-settings

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• 101-Install-eslint-for-code-enforcement
• 101-Perform-checks-for-code-analysis-and-style-enforcement
• 102-Update-room-queue-management-through-Video-and-Playlsit-models
• 104-Enhance-loader-on-new-and-show-liveviews
• 86-As-a-User-I-want-to-see-notification-alerts-When-something-relevant-happens
• 99-Give-the-embedded-player-ability-to-play/pause-other-peers'-players
• add-tests
• adds-room-settings-tests
• adds-show-live-tests
• coverage-tests-refactor
• dev
• develop
• feat/2026-05-23
• feat/es-ar-translations
• feat/ignite-focus-treatment
• feat/layouts-rework
• feat/playlist-arrow-key-navigation
• feature/2026-08-13
• feature/2026-08-15
• feature/add-cd
• feature/add-searched-videos-to-the-queue
• feature/add-videos-update
• feature/add-voume-controls
• feature/auto-end
• feature/chat-avatar-left-of-username
• feature/dark-mode
• feature/general-improvements
• feature/improve-search-bar
• feature/move-theme-to-settings
• feature/multiavatar-integration
• feature/play-videos-on-list-item-click
• feature/playlist-and-player-enhancements
• feature/playlist-keyboard-focus-improvements
• feature/room-settings-modal
• feature/rooms-index-redesign
• feature/rooms-list-rework
• feature/settings-general-tab-avatar
• feature/track-change-browser-notifications
• feature/uiux-improvements-shareable-room-and-header-polishing
• feature/video-player-controls
• features/2026-08-09
• fix/consistent-input-shadows
• fix/focus-ignite-layer-override
• launcher-animation-improvements
• layout-updates
• migrate-to-phoenix-1.6
• peers-tests
• refs/pull/112/merge
• use-a-video-model

Build # db5637a3e8e7def9480d8681fa2caa2ecb83d720-PR-146

Build Type

Pull #146

github

Committed by sgobotta

Commit Message

Fix plain arrows still seeking/adjusting volume on the sliders

The registry's default ignoreInputs guard blocks a scope whenever the
event target's tag is INPUT - meant to stop shortcuts from firing
while typing, but the seek bar and volume slider are also <input>
elements (type="range"), so this scope was silently declining before
ever reaching its own navigation logic whenever either was focused.
Plain arrow keys fell straight through to the native slider behavior
untouched, defeating the self-loop/preventDefault handling added for
them. Opt this scope out of that guard - move()'s own
this.el.contains(active) check already scopes it correctly, since
nothing text-editable lives inside the player controls container.

Adds an integration-level regression test (mounting the hook against
a real fixture and dispatching real keydown events through the
registry) so this class of bug - a scope's own directions being
correct but never reached - can't silently regress again.

Pull Request Pull Request #146: Add a consumer-agnostic keyboard system with explicit grid navigation

Coverage Stats

1472 of 2152 relevant lines covered (68.4%)

30.42 hits per line