orion-ecs / keen-eye / 30292890254

64%

Build Type

push

github

Committed by tyevco

Commit Message

fix(network): Chunk full snapshots and guard sends against transport message limits

The replication layer built one FullSnapshot message containing every
networked entity and handed it to the transport unchecked; UdpTransport
throws on payloads over its 1192-byte MTU budget, so any real-sized
world crashed the server game loop the moment a client connected.

- INetworkTransport gains MaxMessageSize so callers can budget messages
  per transport (UDP 1192, TCP 1 MiB, LocalTransport unbounded).
- SendFullSnapshot packs entities greedily into as many FullSnapshot
  messages as the budget requires. The client handler was already
  incremental, so chunked messages compose without protocol changes.
  A single entity that cannot fit alone is skipped with a diagnostic.
- NetworkServerPlugin's Send/SendToAll/SendToAllExcept drop oversized
  payloads with a diagnostic instead of crashing the game loop.

Four of the seven new tests fail on the unfixed plugin, including a
real-UDP end-to-end test where a 100-entity snapshot converges on the
client across multiple datagrams.

Fixes #1278

Coverage Stats

8984 of 13260 branches covered (67.75%)

Branch coverage included in aggregate %.

53 of 53 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

53143 of 83903 relevant lines covered (63.34%)

1.0 hits per line