orion-ecs / keen-eye / 30227593377

64%

Build Type

push

github

Committed by tyevco

Commit Message

fix(samples): Keep the NOVAFALL ball inside the shaft so a lucky fall cannot escape the floors

A player reported getting the ball past the bottom of the screen, falling
below where floors spawn, and then being unable to collide with anything
while the score climbed forever. The run became unloseable.

The escape is reachable in ordinary play: the ball's terminal fall speed
(1100 u/s) far exceeds the fastest the shaft rises (340 u/s), so threading
a few gaps in a row genuinely outruns the shaft. Nothing bounded
position.Y downward, and floors were only ever maintained down to a fixed
screen-space band (ShaftHeight + FloorSpacing), so once the ball was below
that band no floor could ever exist beneath it and CollisionSystem could
never fire again. Depth — and therefore score — accrues from the scroll
speed rather than from the ball, so it kept climbing; CrushSystem only
tests the ceiling, so nothing could end the run. With adversarial
gap-chasing the escape happens within ~3.5 seconds of play.

The fix clamps rather than kills. NOVAFALL's fantasy is that falling is
safety, so killing a player for threading gaps well would invert it. The
original TI-83 behaviour is the right one: the ball rides the bottom of
the shaft and the rising floors sweep up into it, which is self-correcting
and creates tension instead of punishing good play.

- BallMovementSystem: clamp position.Y to Tuning.ShaftHeight - ball.Radius,
  mirroring the existing wall clamp exactly, and zero the downward velocity
  so a bottomed-out ball rests instead of banking speed it can never spend.
  Zeroing (not bouncing) keeps velocity.Y >= 0, which is what
  CollisionSystem's landing test requires, so a floor rising into a
  bottomed-out ball still lands it normally.
- FloorScrollSystem: fill the shaft relative to max(view bottom, ball)
  instead of the view bottom alone, as defence in depth. Floor identity
  stays a pure function of (seed, floorIndex); with the clamp in place the
  view bou... (continued)

Coverage Stats

8968 of 13251 branches covered (67.68%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 2 files covered. (100.0%)

9 existing lines in 3 files now uncovered.

53087 of 83864 relevant lines covered (63.3%)

1.0 hits per line