orion-ecs / keen-eye
64%

DEFAULT BRANCH: main
Repo Added
Files 1058
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 64.277% (+0.06%) from 64.22%
30376778113

push

github

tyevco 
fix(graphics,samples): Select system fonts by loadability so macOS collections are skipped (#1365)

Every windowed sample failed to load a font on macOS. `/System/Library/Fonts/Helvetica.ttc`
was the first macOS candidate in four duplicated discovery lists, and each list selected on
`File.Exists` alone and returned the first hit. `.ttc` is a TrueType Collection - several faces
behind a `ttcf` header rather than a font table directory - and `SilkFontManager` loads with
`fontSystem.AddFont(File.ReadAllBytes(path))`, which initialises at offset 0, so stb rejected it
with a bare `stbtt_InitFont failed`. Existence is not loadability, so an unusable file shadowed
every later candidate that would have worked.

- Add `SystemFonts` to `KeenEyes.Graphics.Abstractions`: one platform-aware candidate list plus
  `FindFirstUsable()`, which selects by reading the leading 4-byte sfnt tag and skipping anything
  the rasterizer cannot open at offset zero - collections, web formats, truncated or unreadable
  files. The check, not the list, is what stays correct when Apple moves fonts again.
- Reorder the macOS candidates so the single-font files under
  `/System/Library/Fonts/Supplemental` come first and the `.ttc` last. Windows and Linux entries
  are unchanged.
- Replace the four duplicated `FindSystemFont` helpers (Sample.UI, Sample.Showcase,
  Sample.NovaFall, EditorApplication) with calls to the shared locator.
- Name the file and the format when a collection reaches `LoadFont`/`LoadFontFromMemory`, and wrap
  FontStashSharp's anonymous rejection at the boundary, per the #1274 diagnostics contract.
  Collection support itself remains deliberately out of scope.
- Make the Sample.UI and Sample.Showcase catch-alls report what actually failed instead of
  asserting "This sample requires a display" on a machine that had just logged a GL device line
  (third instance of the class tracked in #1256).

Closes #1365

9079 of 13305 branches covered (68.24%)

Branch coverage included in aggregate %.

70 of 76 new or added lines in 3 files covered. (92.11%)

4 existing lines in 3 files now uncovered.

53586 of 84187 relevant lines covered (63.65%)

1.0 hits per line

Relevant lines Covered
84187 RELEVANT LINES 53586 COVERED LINES
1.0 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30376778113 main fix(graphics,samples): Select system fonts by loadability so macOS collections are skipped (#1365) Every windowed sample failed to load a font on macOS. `/System/Library/Fonts/Helvetica.ttc` was the first macOS candidate in four duplicated discov... push tyevco github
64.28
30376572913 fix/macos-font-discovery Merge a09a9f858 into 14a8b0ee2 Pull #1367 web-flow github
64.28
30374356992 main docs: Correct the plugin-install comment about when the OS window is created The comment added in #1259 said SilkWindowPlugin.Install 'creates the window (and therefore initializes GLFW) right here'. Only the second half is true: Install initiali... push tyevco github
64.22
30371985237 fix/macos-main-thread-window Merge 8629e8bd2 into 1cbd5ab75 Pull #1366 web-flow github
64.23
30361115029 dependabot/github_actions/actions/checkout-7 Merge 24df1a5ce into 1cbd5ab75 Pull #1339 web-flow github
64.31
30360962500 main ci: Run the test suite on macOS (non-blocking to start) The suite has never executed on macOS. The only Apple Silicon coverage in the repo was the AOT publish job in aot-compatibility.yml, so ~14,900 tests were unverified on the platform the iOS ... push tyevco github
64.32
30322907581 fix/render-target-texture-id-space Merge 83eaa84f7 into 29dd3ee1d Pull #1361 web-flow github
64.01
30322560592 fix/macos-pipe-path-limit Merge 9f229a3e8 into 29dd3ee1d Pull #1359 web-flow github
63.96
30322295363 main fix(ai): Move all execution state out of shared behavior definitions into per-entity memory Behavior definitions (BT nodes, AI actions, utility actions and considerations) are shared between every entity that runs them, but they stored per-execut... push tyevco github
63.95
30322064196 ci/macos-test-matrix Merge efb954064 into 08ebffe1c Pull #1356 web-flow github
63.93
See All Builds (830)