orion-ecs / keen-eye / 30322295363

64%

Build Type

push

github

Committed by tyevco

Commit Message

fix(ai): Move all execution state out of shared behavior definitions into per-entity memory

Behavior definitions (BT nodes, AI actions, utility actions and
considerations) are shared between every entity that runs them, but
they stored per-execution state in instance fields: composite child
cursors, RandomSelector shuffles, node LastState (which also drives
interrupt propagation), Cooldown timestamps, Repeater counts, WaitNode
elapsed time, all four navigation actions' path state, and utility
scoring debug values. Two entities sharing one definition corrupted
each other's runs - entity B resumed from entity A's position.

Execution state now lives in per-entity memory objects stored on the
entity's Blackboard, keyed by definition-node reference
(Blackboard.GetMemory<TMemory>). Node/action Execute signatures are
unchanged; Reset and last-state access now take the blackboard
(Reset(Blackboard), GetLastState(Blackboard), GetLastScore(Blackboard))
so one entity's reset cannot rewind another's progress. Definitions are
immutable while running and safe to share.

Eight regression tests in SharedDefinitionTests run one shared
definition against two blackboards and assert isolation, including an
end-to-end BehaviorTreeSystem test where a later-spawned entity does
not inherit the first entity's wait progress.

Fixes #1281

Coverage Stats

8987 of 13264 branches covered (67.75%)

Branch coverage included in aggregate %.

133 of 226 new or added lines in 30 files covered. (58.85%)

10 existing lines in 8 files now uncovered.

53177 of 83940 relevant lines covered (63.35%)

1.0 hits per line