orion-ecs / keen-eye / 30098334396

64%

Build Type

push

github

Committed by tyevco

Commit Message

fix(core): ExtensionManager no longer disposes caller-owned or re-set extensions (#1149, #1171)

ExtensionManager disposed extensions unconditionally, causing two bugs:

- #1149: SetExtension disposed the existing instance before storing, with no
  ReferenceEquals guard, so re-setting the SAME instance disposed the live object.
- #1171: RemoveExtension disposed the removed instance unconditionally, so
  NavigationPlugin/DotRecastNavigationPlugin uninstall disposed providers/managers
  the caller (or another still-installed plugin) owned.

Fixes:
- Add a ReferenceEquals guard so re-setting the same instance never disposes it.
- Add ownership tracking: SetExtension gains an `owned` parameter (default true,
  preserving manager-owned dispose-on-replace/remove/clear semantics that existing
  plugins rely on). Caller-owned extensions (owned: false) are never disposed by the
  manager.
- NavigationPlugin registers the always-borrowed provider as owned:false, only removes
  the INavigationProvider registration it actually added, and never self-disposes the
  provider.
- DotRecastNavigationPlugin registers the caller-owned streaming manager and tile cache
  as owned:false.

Caller audit confirmed every plugin that registers an IDisposable extension already
disposes it explicitly in Uninstall, so default owned:true introduces no leaks.

Closes #1149
Closes #1171

Coverage Stats

8477 of 12532 branches covered (67.64%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 5 files covered. (100.0%)

89 existing lines in 10 files now uncovered.

50735 of 79657 relevant lines covered (63.69%)

0.98 hits per line