orion-ecs / keen-eye / 30105812534

64%

Build Type

push

github

Committed by tyevco

Commit Message

fix(generators): Make bundle/serializer/replicated codegen compile for all component shapes (#1137-#1146)

These are latent codegen bugs: the emitted code only broke for type-shapes no
current consumer used, so CI stayed green. Each generator now emits code that
compiles against Core (and round-trips) for the triggering shape, proven by new
consumer-shape tests in KeenEyes.Generators.Tests.

- #1138 BundleGenerator no longer emits a consumer-side `partial class World`
  (which referenced Core-only archetypeManager/PreallocateBundleArchetypes and
  produced a duplicate Query<T>() across bundles). Bundle query/preallocation
  helpers are now extension methods on World (QueryBundleName(), and
  PreallocateBundleArchetypes()).
- #1137 SerializationGenerator no longer applies `?? throw` to non-nullable
  value-type Object fields (enum/Vector2/nested-struct/char) in the JSON and
  binary deserialize paths (CS0019).
- #1139 Binary string writes null-coalesce to string.Empty (no ArgumentNullException).
- #1140 Bundle Get/ref side strips nullability (no world.Get<T?>, CS0453).
- #1141 Every generator's field collection skips IsImplicitlyDeclared fields, so
  auto-property backing fields no longer emit invalid <X>k__BackingField.
- #1142 Nested-bundle fields recurse into a generated Add{Bundle}(World,Entity,bundle)
  overload instead of world.Add(entity, bundle) (CS0315).
- #1143 [Replicated] long/ulong fields emit real write/read code (two 32-bit ops)
  instead of #error.
- #1144 Serializer member/local identifiers are disambiguated by namespace so two
  same-named components in different namespaces no longer collide (CS0111/CS0128).
- #1145 Regression test locks in the existing KEEN100 diagnostic for >32 replicated fields.
- #1146 Migration graph gains edges for auto-migrations, so FindGaps no longer
  contradicts CanMigrate.

Closes #1137
Closes #1138
Closes #1139
Closes #1140
Closes #1141
Closes #1142
Closes #1143
Closes #1144
Closes #1145
Closes #1146

Coverage Stats

8495 of 12544 branches covered (67.72%)

Branch coverage included in aggregate %.

123 of 128 new or added lines in 6 files covered. (96.09%)

2 existing lines in 2 files now uncovered.

50829 of 79715 relevant lines covered (63.76%)

0.98 hits per line