orion-ecs / keen-eye / 30065900749

64%

push

github

test: Make ConeShape and JobHandle_Wait tests deterministic under parallel load (#1206)

Two pre-existing tests flaked only under `--max-parallel-test-modules 32`,
blocking parallel CI (#1204). Both are now deterministic.

ParticleSpawnSystemTests.SpawnSystem_ConeShape_SpawnsInConeDirection:
- Root cause was swapped arguments to EmissionShape.Cone(radius, angle,
  direction): the test passed PI/4 as the radius and 10f (10 radians ~ 573
  degrees) as the spread angle. That huge spread meant only ~37% of particles
  pointed rightward, hovering near the `>= 25` floor and dipping to 24 under
  variance. Fixed the argument order to a genuine 45-degree rightward cone,
  seeded the World for reproducibility, and replaced the weak "25% rightward"
  count with a per-particle assertion that every particle travels within the
  cone half-angle (+/-22.5 degrees) of the axis. This still fails if the spawn
  system ignores the cone direction/angle.

JobSchedulerTests.JobHandle_Wait_TimeoutReturnsCorrectly:
- The 10ms timeout raced a 100ms sleeping job; under ThreadPool contention the
  waiting thread was descheduled past 100ms, the completion event was signaled,
  and Wait returned true. Replaced the sleeping job with a gated job whose
  completion is externally controlled, so Wait must time out (false, not
  completed) while the gate is closed and must succeed (true, completed) once
  opened - asserting the behavior rather than a wall-clock window, mirroring
  the #1053 approach.

Verified with 20 consecutive full-suite runs at
--max-parallel-test-modules 32: 0 failures, 0 hangs.

Closes #1206

8460 of 12523 branches covered (67.56%)

Branch coverage included in aggregate %.

50645 of 79622 relevant lines covered (63.61%)

0.97 hits per line