orion-ecs / keen-eye / 30065019554

64%

Build Type

push

github

Committed by tyevco

Commit Message

test(editor): Isolate EditorSettings global state so editor tests are parallel-safe (#1203)

EditorSettings is a process-global static class (shared _data, _settingsPath,
_isLoaded, and a static SettingChanged event that HotReloadService subscribes to).
xUnit parallelizes test collections within an assembly, so editor test classes that
touch this shared state clobbered each other under load, flaking ~10% of parallel
runs (HotReloadServiceTests, EditorApplicationViewportTests).

Fix, two layers:
- Disable collection parallelization for KeenEyes.Editor.Tests via a project-local
  xunit.runner.json (parallelizeTestCollections=false). The repo-wide
  tests/xunit.runner.json enables collection parallelism and its copy (via
  Directory.Build.props) takes precedence over any [assembly: CollectionBehavior]
  attribute, so the csproj drops that copy for this project and ships the local one.
  Cross-assembly parallelism (--max-parallel-test-modules) is unaffected.
- Add EditorSettings.ResetForTesting() (internal, exposed via existing
  InternalsVisibleTo) that clears in-memory settings to defaults, forgets the
  settings path, marks settings not-loaded (so mutations don't hit disk), and
  detaches all SettingChanged subscribers. Called from the ctor/Dispose of the three
  affected editor test classes so bleed is impossible even sequentially.

Verified: full suite at --max-parallel-test-modules 32, 15 runs, editor tests 0
failures / 0 hangs.

Closes #1203

Coverage Stats

8460 of 12523 branches covered (67.56%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

8 existing lines in 1 file now uncovered.

50646 of 79622 relevant lines covered (63.61%)

0.97 hits per line