orion-ecs / keen-eye / 30060975494

64%

Build Type

push

github

Committed by tyevco

Commit Message

fix(core): Harden MessageManager dispatch against reentrancy and cross-handler unsubscribe (#1108, #1109, #1113)

Snapshot the handler list before dispatch in Send, ProcessQueuedMessages<T>,
and MessageQueueWrapper.Process so a handler can unsubscribe itself or any
other handler without shifting the set of handlers seen by the current
dispatch. This fixes the double-invoke where reverse-iterating the live list
re-ran a just-run handler after it removed an earlier-indexed one (#1109).

Snapshot the queue set in ProcessQueuedMessages before dispatch so a handler
queuing a never-before-seen message type (adding a dictionary key) no longer
throws 'Collection was modified'; newly-queued types are delivered on the next
drain. Drop the trailing clear-all pass that could silently discard a message
a handler just queued (#1108).

Iterate forward in both EventBus and MessageManager to honor the documented
'registration order' contract instead of reverse (#1113).

Closes #1108
Closes #1109
Closes #1113

Coverage Stats

8463 of 12523 branches covered (67.58%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 2 files covered. (100.0%)

72 existing lines in 4 files now uncovered.

50647 of 79617 relevant lines covered (63.61%)

0.97 hits per line