Unleash / unleash / 29569171275

87%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: no phantom feature delete events

## Summary

Fixes an audit-log inconsistency where deleting a feature that was not
actually removed could still emit a `feature-deleted` event.

The store already guarded deletes so only archived flags can be removed,
but the service layer emitted delete events based on intent rather than
the rows actually deleted. This could leave the DB with a live feature
while the event log said it had been deleted.

## What changed

- Added a failing regression test first, following a brief TDD flow, to
capture the no-op delete/event mismatch.
- Consolidated singular feature delete through the plural
`deleteFeatures([featureName], projectId, auditUser)` path.
- Fixed the plural delete eligibility check to use `toggle.archived`
instead of `archivedAt !== null`.
- Changed `batchDelete` to return the deleted feature rows via `DELETE
... RETURNING`, so events are emitted only for rows that were actually
removed.
- Kept the legacy archive delete behavior idempotent: no-op deletes
still return success, but no longer emit phantom `feature-deleted`
events.

Coverage Stats

1938 of 2135 branches covered (90.77%)

13 of 13 new or added lines in 4 files covered. (100.0%)

5 existing lines in 3 files now uncovered.

15525 of 17752 relevant lines covered (87.45%)

807.77 hits per line