Unleash / unleash
87%
master: 91%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Repo Added
Files 1180
Badge
Embed â–¾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 87.125% (-0.004%) from 87.129%
26441993136

push

github

web-flow 
feat: add flag-gated `cleanupCount` on /api/admin/projects (#12103)

As part of the project cards redesign, we want to include a mention of
the number of flags in clean up, so this:

- Adds `cleanupCount` to the `/api/admin/projects` response if the
`newProjectList` feature flag is enabled (`cleanupCount` represents the
number of features currently in `completed` lifecycle stage for the
project).
-
[src/lib/features/project/project-service.ts](https://github.com/Unleash/unleash/pull/12103/changes#diff-6ca938c853245e8796001e79972100743R265)
fetches `featureLifecycleReadModel.getStageCountByProject()` alongside
the existing onboarding-status call via `Promise.all`. Each fetch has
its own `.catch` returning an empty `Map`, so a failure in one doesn't
take down the other.

## Performance considerations 

This PR adds a new caller of `getStageCountByProject()` to a somewhat
critical admin endpoint.
If this causes performance issues once we enable the flag, we could
consider either of the following follow up tasks to mitigate:
- **Index migration on `feature_lifecycles`**: add `(feature, created_at
DESC)`. The query relies on `DISTINCT ON (feature) ORDER BY feature,
created_at DESC`, and no matching index exists today (only the PK on
`(feature, stage)`), so Postgres falls back to a sort. The index would
let it scan in order instead.
- **Move lifecycle counts per stage to a separate endpoint and lazy-load
on the frontend**. We could also consider only loading a project
lifecycle count if the card is visible on viewport.
 
For now, since we already fetch all feature flag lifecycles for all
projects in `/insights` (Analytics page), I'd merge as-is and only
remediate if it becomes an issue.
Shoutout to @melindafekete and @gergokekesi for discussing this with me
💖

1852 of 2047 branches covered (90.47%)

10 of 12 new or added lines in 2 files covered. (83.33%)

1 existing line in 1 file now uncovered.

15118 of 17352 relevant lines covered (87.13%)

927.11 hits per line

Relevant lines Covered
17352 RELEVANT LINES 15118 COVERED LINES
927.11 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26441993136 main feat: add flag-gated `cleanupCount` on /api/admin/projects (#12103) As part of the project cards redesign, we want to include a mention of the number of flags in clean up, so this: - Adds `cleanupCount` to the `/api/admin/projects` response if t... push web-flow github
87.13
26440680405 main task: Move to AGPL-v3 (#12086) This changes the license of opensource to be AGPL-v3.. Things to consider: - Do we own all the code in our repository? - The docker image will now also be AGPL-v3, should be fine for the OSS image. push web-flow github
87.13
26287636064 main chore(deps): update cypress-io/github-action action to v7 (#12029) push web-flow github
87.11
26223857272 main feat: use one flag to control all impact metrics (#12088) push web-flow github
87.08
26223597351 main feat: include flag-gated `onboardingStatus` on /api/admin/projects (#12082) - Adds `onboardingStatus` to the `/api/admin/projects` response if the `newProjectList` feature flag is enabled (if it's not enabled, it's omitted). - Breaks out the onbo... push web-flow github
87.13
26223123294 main chore: include patches directory in docker build (#12089) To allow package patches to be included in the docker build. push web-flow github
87.12
26222193357 main chore: migrate react table v7 to v8 (#11967) Migrate from react-table v7 to TanStack Table v8 ## Summary Replaces `react-table` v7 with `@tanstack/react-table` v8 across the frontend. The migration was staged in ~25 small phases (phase 1 founda... push web-flow github
87.08
26210664412 main feat: check frontend API cache readiness before accepting traffic (#12083) - Adds a cache readiness check to the `/api/health/ready` endpoint that returns 503 until the `GlobalFrontendApiCache` has finished its initial load - The check is a pure... push web-flow github
87.12
26175269781 main feat: add groups to user access overview endpoint (#12084) push web-flow github
87.1
26175188828 main feat: add groups to user access overview endpoint (#12084) push web-flow github
87.11
See All Builds (9000)