Unleash / unleash
89%
master: 91%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Repo Added
Files 1264
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 88.76% (-0.008%) from 88.768%
43435919973

push

github

web-flow 
fix: refuse a change request that deletes a segment in use

## Summary

Applying a change request that deletes a segment no longer strips it
from the live strategies that still use it. It now answers 409, like a
direct `DELETE` does, and says why. That's
[EG-4930](https://linear.app/unleash/issue/EG-4930).

## Key points

- A change request that deletes a segment a live strategy uses is
refused, and the whole change request rolls back. A live strategy is any
strategy on a flag that isn't archived, including one on an active
release plan milestone.
- A change request that deletes an unused segment still applies.

## Why

A direct `DELETE` of a segment in use answers 409, because the route
checks for use first. Applying a change request goes through
`unprotectedDelete` instead, which had no usage check. So the delete
went through. The foreign key dropped the segment from every strategy
that used it.

No event named a flag, so the environment's revision didn't move.
Without such an event, SDKs weren't told about the strategy change.
Polling SDKs picked it up at the next unrelated change in that
environment. They served the strategy without that segment. So users the
segment had excluded could get the flag. At that same change, delta SDKs
got `segment-removed` and no update for that flag. After that change, a
delta SDK starting fresh got the segment id with no definition. That
turned the strategy off.

With this change, the apply checks for live strategies using the segment
before deleting it, and refuses with a 409.

The check and the delete aren't locked against each other. So a strategy
that gets the segment attached while the apply runs can still lose it. A
direct `DELETE` has the same window today.

## Testing

- It only adds the usage check to the change request apply. The direct
`DELETE` route stays as it is.
- The check lives in the OSS segment service, but only the change
request apply calls it. So only Enterprise and Cloud behave differently.
- ... (continued)

4210 of 5300 branches covered (79.43%)

0 of 3 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

16859 of 18994 relevant lines covered (88.76%)

826.27 hits per line

Relevant lines Covered
18994 RELEVANT LINES 16859 COVERED LINES
826.27 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
43435919973 main fix: refuse a change request that deletes a segment in use ## Summary Applying a change request that deletes a segment no longer strips it from the live strategies that still use it. It now answers 409, like a direct `DELETE` does, and says why.... push web-flow github
88.76
43434493736 main chore: harvest strategy validation into its own service Release plans currently do virtually no validation. That's Really, Really Bad™ because invalid configurations can cause parse failures in SDKs - that in turn means feature flags can stop wor... push web-flow github
88.77
43429019315 main fix: scope milestone strategy updates to the feature's release plan Fixes an issue where you could update strategies belonging to release *templates* and strategies belonging to other features/envs as long as they were milestone strategies. Does... push web-flow github
88.76
43403292931 main feat: enforce payload schema on milestone strategy edit push web-flow github
88.77
43264868274 main feat: render dashboard onboarding widgets https://linear.app/unleash/issue/SA-1261/render-the-onboarding-widgets-on-the-dashboard Shows the new onboarding widgets behind `dashboardV2Widgets` flag, alongside `dashboardV2`. Users who can create fl... push web-flow github
88.76
43260799951 main feat: user from an account token lookup carries the token id Adding the token id to the user when a request is authenticated with a personal access token or a service account token, so code handling the request can tell it came from a token and w... push web-flow github
88.76
43244182938 main feat: enforce payload schema on strategy write push web-flow github
88.77
43237278704 main chore: remove unused onboardingIntroTour flag > - Removes `onboardingIntroTour` from the experimental flag names. Nothing in the codebase reads it anymore. > - `onboardingIntroTourAdvancedTopics` stays; it's still in use. push web-flow github
88.73
43225588009 main feat: introduce app shell and new colors for navigation rework Behind `improvedSidebarNavigation` feature flag. This is just a empty shell with a logo. I introduced new theme properties group: appShell, with 2 fields: background and sidebar. push web-flow github
88.74
43224988332 main feat: payload schema store push web-flow github
88.74
See All Builds (9723)