agama-project / agama / 29510351317

83%

push

github

web: Avoid displaying a wrong reused filesystem type (#3732)

## Problem

When reusing an existing filesystem, the web UI shows a message like,
for example, "Current XFS at /dev/sb4". But the problem is that, in that
example, "XFS" is not really the current file-system type (which will be
kept), but the default file-system type that would be used if the device
would actually be re-formatted.

It is just a "cosmetic" error, since the proper operation is actually
performed.

## Solution

Omit the filesystem type. So instead of "Current XFS at /dev/sb4" the
string "Current /dev/sdb4" would be used. The string was already there
for other cases, so there is no impact in the translations and the
meaning of the sentence basically stays.

It would also be possible to inspect the current system to calculate the
real filesystem type that will be re-used and display that instead. But
the implemented fix is much easier and good enough for the SLE RC phase
(in which we want to be conservative with the changes).

## Testing

- Tested manually

## See also

Another solution was implemented in the model layer (see #3726), but we
are not sure whether is formally correct, so we opted for this simpler
solution for now.

4899 of 6836 branches covered (71.66%)

Branch coverage included in aggregate %.

25585 of 29839 relevant lines covered (85.74%)

123.82 hits per line