agama-project / agama

80%

master: 83%

LAST BUILD ON BRANCH popup-refactor

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• AY_bridge_vlan_support
• MarkedString
• SLE-16
• SLE-16-self-update
• SLE-16-self-update-scc
• VLAN_UI
• VLAN_UI_changes
• action_permissions
• actions-readable-with-env
• adapt-gnome-kiosk-options
• adapt_network_UI
• adapt_to_v2
• add-check
• add-fields-support-for-additonal-label
• add-inst-script
• add-missing-gems
• add-more-libzypp-callbacks
• add-noto-sans-for-cyrillic-script
• add-questions-logging
• add-signature-callbacks
• add-system-page
• add_custom_repos
• add_ipconfig_link_local4
• add_ovs_support
• added_mysed_type
• adjust-webpack-config
• after-install-snapshot
• after-release-beta2
• agama-22
• agama-22-local-monaco-editor
• agama-api-v2_network
• agama-api-v2_network-UI
• agama-api-v2_network-backend
• agama-config-generate
• agama-files-errors
• agama-iscsi-service
• agama-new-api
• agama-new-api-actors
• agama-new-api-ci
• agama-new-api-progress
• agama-new-api-traits
• agama-product-modes
• agama-product-registration-fix
• agama-profile-apiurl
• agama-screenshot
• agama-v2_hostname
• agama_config_insecure_rc3
• agama_config_return_codes
• agama_config_return_codes_SLE-16
• agama_download_insecure
• aide
• allow-more-ui-styles
• always-display-install-button
• answers_interactive
• api-option
• api-v2
• api-v2-product-selection
• api-v2-progress
• api-v2-storage-reset
• api-v2_network
• audit-fix
• auto-insecure
• auto-scripts
• autoinstall_fix
• autologin-schema
• autoyast-iscsi
• autoyast-skip-list
• ay-services-manager-conversion
• backport-beta2
• beta2
• better-agama-auto
• better-config-dialog
• better-error-message
• better-logging
• better-logs
• better-network-breadcrumb
• better-progress-indicator
• better-software-errors
• better-system-icon
• better-testing
• better-url-handling
• better_boot_solver
• better_fs_reuse_pure_ui
• better_reg_errors
• better_reuse_ui
• bind_interface
• bls_efi
• bond-validation-testing
• bond_UI
• bond_UI_decouple_type
• bond_UI_reorganize_validations
• boot-raid
• boot-two-sizes
• boot_from_candidate_raid
• bootloader-system
• bootloader_config
• bootloader_force_user_input
• bootloader_new_api
• bridge_UI
• bridge_support
• bsc#1234711
• bsc#1263808
• bsc-1233160
• bsc-1245187
• bsc-1247248
• bsc-1248876
• bsc-1251898
• bsc-1251898-security
• bsc-1257489
• bsc-1257930
• bsc-1258450
• bsc-1259533
• bsc-1261787
• bsc1243795-sle16
• bsc1244697
• bsc1244697_rc3
• bsc1249591
• bug_partitioned_raid
• bug_partitioned_raid_master
• bump-rustc
• bundler-cache-16.0
• busy_state_calc
• cache-control
• cached_software
• cancel-link
• candidate-devices
• carry_over_hcn
• catch_no_root
• change-progress-subscriptions
• changes
• changes-bsc-1257930
• check-encryption-password
• check_issues_backend
• checkmedia
• chore-storage
• ci-caching
• ci-doc-fix-rubygem
• ci_augeas_06
• ci_autoinst_schema
• ci_rust_cache
• clean-ay-profile
• clean-up
• clean-up-registration
• cleanup
• cli-offline-validation
• cli_status
• client-id
• clippy
• collect-logs
• configure_console_font
• confirm_format
• conflicts
• coveralls_config
• create_if_not_found
• current_installation_phase_nil
• dasd-dbus-api-v2
• dasd-http-api-v2
• dasd-page-refactoring
• dasd-ui-api-v2
• dbus_nm_versions
• dead-code-cleanup
• debug-product-cache
• decouple-download-feedback
• default-mode
• default_auto
• delete-proposed-drive
• delete-proposed-partition
• delete-vg
• delete_root_again
• delete_root_beta2
• dependabot/npm_and_yarn/web/share/po/isaacs/brace-expansion-5.0.1
• desktop-selection-in-summary
• device-selector-sorting
• dirty-wip-dasd-ui-experiment
• disable-cfg-ci-lint
• disable-remote-access
• disable-remote-access2
• disable-self-update
• disable_bench_tests
• disable_gpt_auto_generator
• disable_h264_master
• disable_local_repos
• disconnect_not_bound_devices
• display-load-error
• distrobox
• dns_priority
• do-not-reset-config
• download-api
• download-config
• dracut-i18n
• dracut-ntp
• dracut_hnc_poc
• drop-custom-alerts-css
• drop-dbus-l10n
• drop-dead-css
• drop-deviceselection
• drop-jsdoc
• drop-local-web-ui-path
• drop-model-lists
• drop-network-dead-code
• drop-overview-from-path
• drop-registration-alert
• drop-registration-alert-i2
• drop-route-handle-metadata
• drop-scope
• drop-typedoc
• drop-unused-module
• drop-xf86-packages
• drop_32bit
• drop_network_dbus_leftovers
• dud
• dud-kernel
• dud-support
• dud_repository
• early-feedback
• edit-vg
• editorconfig-fixes
• efi_locale
• empty-ay
• empty_search
• enable-agama-scripts
• enable-dbus-monitor-live
• encode_connection_id
• encrypted_password
• encryption_methods
• enhance-network-connection-form
• env-storage
• errorboundary
• esp-id
• eula-support
• expand_search
• expanded_lvs
• expanded_partitions
• explicit_boot_raid_upstream
• export-password
• export-solved-config
• expose-passwords
• extend-transfer-urls
• extended_collected_logs
• fast_rust_unit_tests
• faster-product-redirection
• feature-bls
• feature-bls-sync1
• feature-desktop-selection
• feature-reuse-vg-ui
• feature-storage-forms
• feature-terminal
• feature-unsaved-changes
• files-service
• files_auto
• files_ay_convertor
• filesystem-fields
• finish-feature-bls
• finish-phase
• finish_order
• first_software_fixes
• fix-DOM-nesting-at-login
• fix-actions-handling
• fix-agama-autoyast
• fix-agama-tests
• fix-auth-and-encryption-switches
• fix-autoselected-patterns
• fix-ay-pre-scripts
• fix-ay-support
• fix-bls-config
• fix-bsc-1243415
• fix-bulk-selection
• fix-button-ri
• fix-config-read-only
• fix-converter
• fix-copy-paste
• fix-dasd-deactivation
• fix-devices-fields
• fix-downloadfeedback-test-flake
• fix-duplicated-aria-in-system
• fix-env-bls
• fix-error-format
• fix-error-reporting
• fix-extensions-layout
• fix-fetch-logs
• fix-firstboot-keymap
• fix-inst-finish
• fix-installer-options-form-state
• fix-installer-options-state-sle-16-qu
• fix-integration-tests
• fix-isChecked-at-product-selection
• fix-isChecked-prop
• fix-iscsi
• fix-keymap
• fix-keymaps-i18n
• fix-l10n-context
• fix-l10n-reload
• fix-label-product-selection
• fix-lang-conversion
• fix-language-change
• fix-list-repositories
• fix-load-translations
• fix-local-web_ui-path
• fix-localectl-mock
• fix-locales-test
• fix-logs-filename
• fix-long-string
• fix-lvm-selector-text
• fix-manager-tests
• fix-maring-inline-start
• fix-md-checker
• fix-menubutton-flip
• fix-minimal-layout-masthead-space
• fix-missing-translations
• fix-missing-translations-sle16
• fix-monitor
• fix-monitor-sync
• fix-mount-point-flicker
• fix-network-encoding
• fix-network-method
• fix-network-persist-rc3
• fix-openapi
• fix-openapi-schema
• fix-opening-ssh-port
• fix-overview-and-progress
• fix-overview-and-progress-v2
• fix-packaging
• fix-password-check
• fix-pattern-selection
• fix-patterns-selection-form
• fix-pf-react-styles
• fix-post-partitioning-scripts
• fix-prefix-handling
• fix-probe-dasd-format
• fix-product-appearance-flash
• fix-product-cache
• fix-product-change
• fix-product-change-again
• fix-products-cache
• fix-queries
• fix-questions
• fix-questions-path
• fix-registration
• fix-registration-workflow
• fix-rules
• fix-s390-detection
• fix-schema
• fix-scripts
• fix-scripts-reader
• fix-selected-product-cache
• fix-selector-keyboard-navigation
• fix-services-manager-reader
• fix-set-config-model
• fix-set-keymap
• fix-software-cache
• fix-software-proposal
• fix-software-queries
• fix-storage-activation
• fix-storage-system
• fix-storage-tests
• fix-storage-types
• fix-storage-ui
• fix-suggestions-text-field-race-condition
• fix-system-information
• fix-tasks-prescripts-dep
• fix-tests
• fix-transfer
• fix-translations
• fix-urls
• fix-user-settings
• fix-users-summary
• fix-web-build
• fix-ws-connection
• fix-zfcp-issues
• fix_and_validate_JSON_schema
• fix_apply_network_changes
• fix_autoconnect_of_ports
• fix_bootconfig
• fix_cmdline
• fix_copy_certificates
• fix_delete_bridge
• fix_diskless_inst
• fix_gpg_callbacks
• fix_icewm_setup
• fix_install_url
• fix_integration_tests
• fix_iscsi_ui
• fix_kernel_filtering
• fix_match_SLE-16
• fix_multipath_env
• fix_product_selection
• fix_products_spec
• fix_raid
• fix_repo_copy
• fix_resolv_conf
• fix_shell_injection
• fix_software_progress
• fix_startup_1
• fix_storage_config
• fix_unattended_rmt
• fix_user_import
• fix_vlan_flags-SLE_16
• fix_web_build
• fix_web_pot_sle16
• fix_wpa_eap_suite_b_192
• focus-login-password-field
• force-sizes
• fork-ts-checker-webpack-plugin
• full-packages-repo
• generate_pvs
• get-resolvables
• gh-2647
• gh-3425
• gitignore_openapi
• global-live-region
• gnome-kiosk-wrapper
• gpg-callbacks
• hackweek-ancor
• hackweek-config
• handle-lshw-errors
• handle-nil-passwords
• handle-nil-passwords-master
• hardware_types
• hashed_pasword
• hcn_multiple_bonds
• header-redesign
• hide-passwords
• hide_abort_option
• hightlight-row
• hostname-ui
• hostname_handling
• hot-fix-start-progress
• hotfix_tpm
• http_api_polish
• huha-fix-example
• hw_enablement_flag
• i18n
• i18n_web_refactoring
• ibft-yast-iscsi
• ignore_not_existing_active_connection
• immutable_info
• immutable_proposal
• import-autoyast-scripts
• import-ssl-certs
• improe-software-sections
• improve-agama-status
• improve-disabled-text-contrast
• improve-download-feedback
• improve-events
• improve-font-rendering
• improve-issues
• improve-logging
• improve-partition-form
• improve-reboot-feedback
• improve_logging
• improve_zypp_callbacks
• increase_read_timeout
• info_param
• inhibit
• inline-monitor
• insecure-users-crate
• inst-finish
• install
• install_addon_products
• install_dir
• installation-finished-with-logs
• installation_failed_ui
• installation_finished_tpm
• installer-client-gate
• installer-l10n-options-a11y
• integrate_agama_zypp
• interactive_network_config
• invalid-locale
• ipmi
• ipmitool-fix-percent
• is-waiting-deferred
• iscsi-api-v2
• iscsi-discovery
• iscsi_target_names
• iso_label
• issue-2539
• issue-2662-fix-example-file
• issue-reorg
• itest-green
• json_devicegraph2
• kalpa
• keymap-only-local-connection
• kiwi-use-default-ruby
• l10n-service
• lang-and-keyboard-improvements
• leapmicro
• libzypp-errors
• libzypp_timeout_retry
• licenses-openapi
• licenses-translations
• limit-tokio-threads
• limit_build_jobs2
• link_resolv
• listen_network_improvements
• live_build
• live_shellcheck
• llvm_tarpaulin
• load-profile-from-medium-16.0
• local-monaco-editor
• locale-packaging-conflict
• localize-products-description
• log-failure-details
• log-progress-changed
• log_errors
• logs_api
• loopback-binding-fix
• lsm_select
• lvm-form
• lvm-vg-strategy
• lvm_assembly_fix
• lvm_wording
• mac_address
• malformed_product_yaml
• manager-service
• master
• merge-SLE-16
• merge-api-v2
• merge-master
• merge-sle-16
• merge-sle16
• merge_api-v2
• merge_api_w2
• merge_leap16
• merge_leap_16.0
• merge_master_reg
• merge_rc3
• migrate-formattable-device-form
• migrate-l10n-page
• migrate-lv-form
• migrate-partition-form
• migrate-partition-form-changes1
• migrate-product-selection-form
• migrate-space-policy
• migrate-users-form-tanstack
• missing-redirections
• missing_textdomain
• missing_translations_SLE16
• missing_translations_master
• mkfs_args
• model-bootloader-tpm
• modes-improvements
• monitor
• monitor-summary
• monitor_improvements
• more-reproducible
• more_options
• move_to_json
• multiple_ssh_keys
• network-202603
• network-binding-improvements
• network-device-picker
• network-fixes
• network-persistent-connections-handling
• network-tanstack-form
• network-tanstack-form-part2
• network-tanstack-form-part3
• network-tanstack-form-part4
• network-tanstack-form-part5
• network-tanstack-form-part6
• network-tanstack-form-part7
• network-tanstack-form-part8
• network_backend_fixes
• network_devices_UI
• network_dhcp_settings
• network_improvements
• network_service_feature
• network_settings_optional
• network_startup_install
• network_state_fixes
• new-issues-api
• new-monitor-ui
• new-questions
• new-storage-client
• new_api_save_logs
• new_auth_model
• new_gettext_sle16
• new_libzypp_callbacks
• next
• nm_autoconnect
• no-client
• no_error_loding_default_profile
• no_more_fake_raids
• no_sysinfo_in_status
• no_warning_on_skip
• non-blocking-issues
• non-blocking-progress
• nonEFI-fix
• not-available-desktops
• noto-sans-as-fallback
• npm-audit
• npm-cves-2026-07-master
• npm-cves-2026-07-sle16
• ntp
• ntp-ay
• online_demo
• only_candidates
• only_required
• only_required_sles
• only_required_sles_test
• only_resize_existing
• openapi
• openapi-scripts
• openapi_extended
• optional-ipconfig-vectors
• out-of-sync-toast
• overview-to-installation
• patch-1
• patch-product-selection
• patch_search_lvm
• pattern_search_fix
• patternfly-6
• patterns-search-url
• patterns-selection-form-improvements
• patterns-selection-tanstack-form
• pervasive-encryption
• pfv6-round-1
• pfv6-round-3
• plural-form
• plymouth_s390
• po_merge_17888380480
• po_merge_18068702331
• po_merge_29720230690
• po_merge_sle16_26017657410
• po_service_merge_17888381247
• po_service_merge_18068703236
• po_service_merge_31991471021
• popup-refactor
• post-partitioning-scripts
• post_install_fix
• post_install_zypp_lock
• pre-scripts
• prefer_local
• preselect-selinux
• preserve-ay-pre-scripts
• prevent_ip_disabled
• prevent_ip_disabled_SLE16
• probe-action
• probe_agama_proposal
• product-not-found-empty-state
• product-registration
• product-selection-form-fixes
• product-theming
• product-theming-docs
• product_fix
• product_registrion_poc_fix
• product_translated
• products_po_merge_sle16_17523186155
• profile-checker
• profile-help-typo
• profile_client
• proxy_setup
• query-key-factories
• question-ids-and-labels
• questions-config
• radashi
• raid_editor
• ratatui-monitor
• rc1
• rc1-fix-product-change
• rc3
• rc3-sync
• react-router-v7
• read-only-editor
• read-only-field
• readable-test
• reboot
• redirect-product
• reduce_retries
• register_addons
• registration-error
• registration-stop-listening-software
• registration-summary
• registration-url
• registration_crate
• registration_finish
• registration_progress
• relative-urlref-files
• relax_dependencies
• release-12
• release-15
• release-16
• release-17
• release-18
• release-19
• release-20
• release-21
• release-22
• release-23
• release-api-v2
• rellocate-install-tooltip
• remote-config-edit
• remote_access
• remove-dbus-users
• remove-dead-code
• remove-dead-emptystate-cluster
• remove-fixme
• remove-setxkbmap
• remove_binding_link
• rename-navigation-to-install-button
• rename_cmdline_args
• reorder_storage_ui
• replace-symlinks
• replace_software
• repo_gpg
• repository_retry
• reprobe
• reprobe_button
• requires_only_flag
• rescan-devices-progress
• reset-product
• reset_bootloader_cache
• reset_resolvables
• reset_storage
• restore-dasd-format-progress
• restore-y2dir
• rethinking-encryption-layout
• retry-error
• retry_load_improvements
• retry_pkg_install
• retry_registration_cli
• return-of-ipmi
• reuse-vg-fixes
• reuse-vg-model
• reuse-vg-ui
• reuse-vg-ui-component-api-changes
• revam-iscsi-ui-draft
• revamp-hostname-page
• revamp-software-page
• revert-eslint-removal
• revert-suggestions-fields-usage
• revert-unsigned-repo
• review-translated-strings
• rework-installation-progress
• rework-page-shell
• rework-split-info-layout
• rework-users
• rfc-9457-problem-details
• rmt_extension_fix
• rmt_registration
• rmt_registration_fix
• rubygem-subpackage
• run-chrooted-scripts
• run-init-scripts
• rust-translations
• rust_ci
• rust_faster_ci
• rusty-manager
• scc-proxy
• schema-URL
• schema-p1
• search_lvm
• search_sort
• security_adapt
• security_callbacks
• select-addon-product
• select-packages
• select-packages-proposal
• select-raid
• self-update-fallback
• selinux_fix
• show-config
• simplify-issues-alert
• single-product-init
• sle-16
• sle-16.1
• sle16-backport-fixes
• soft-ser_merge_master
• software-default-answer
• software-page-empty-state
• software-probe
• software-service
• software-service-api-v2
• software-service-boost-1
• software-service-cleanup
• software-summary-issues
• software_no_proposal
• software_service_queries
• software_solve_commit
• software_summary_screen
• software_system_refactor
• software_test_robust
• sort-l10n
• sorted-products
• spaces_in_translations
• split-page-layouts
• split_storage_finish
• sshKey
• sshPublicKey_doc_autoyast_compat
• ssh_keys_fix
• startmode_bootproto
• stop-using-typeaheadcreatable
• storage-add-partition
• storage-basename-options-api
• storage-boot-model
• storage-config-model
• storage-config-null
• storage-config-to-json
• storage-config-ui
• storage-config-ui-encryption
• storage-config-ui-master-sync-20250128
• storage-config-ui-merge-master
• storage-config-ui-show-result
• storage-config-ui-sync-20250219
• storage-config-ui-sync-master-20250121
• storage-configurator
• storage-edit-partition
• storage-fix-conversions
• storage-fixes
• storage-forms-fixes
• storage-fs-label
• storage-generate-pvs
• storage-inhibitors
• storage-label-improvements
• storage-layout-cases
• storage-lvm
• storage-missing-config
• storage-new-api
• storage-new-api-ags8
• storage-new-api-schema1
• storage-new-api-schema2
• storage-refinements-jun-25
• storage-reload
• storage-reprobe
• storage-reset-config
• storage-schema-index
• storage-search
• storage-search-filesystem
• storage-search-new-conditions
• storage-search-operators
• storage-search-partitions
• storage-selector
• storage-selector-ancor
• storage-selector-new
• storage-set-config-model
• storage-show-config
• storage-show-vgs
• storage-truncate-device-names
• storage-ui-new-api
• storage-ui-state-url
• storage-volume-keywords
• storage_merge_master
• storage_reprobe_fix
• store_no_product
• switch-to-wayland-and-gnome-shell
• sync-SLE-16
• sync-api-v2
• sync-api-v2-again
• sync-branch
• sync-queries
• sync-software
• system_cleaning
• systemd-boot-preview
• systemd_kernel_params
• systemd_link
• tables-url-state-dasd-filters
• tables-url-state-sorting
• tasks
• tasks-follow-up
• terminal-texts
• test_fix_rust
• threaded_zfcp
• timeout-stop-on-boot-menu
• timeout_and_retry
• tpm-sdboot
• tpm_pbkdf
• translatable-cli-help
• translatable-cli-help-builder
• translate-mode
• translate_scc_messages
• translated_string
• translations
• try_ibft_reorder
• try_ibft_reorder_master
• typo
• ui-fixes
• ui-fixes-and-improvements
• ui-format-device
• ui-improvements-202410
• ui-polish-rough-edges
• ui-progress
• ui-remove-dead-code
• ui-size-improvements
• ui-sync
• ui-tpm-bls
• ui_event_handling
• ui_password_check_drop
• unattended_multipath
• unify-text
• unselect_patterns
• unsigned-repo
• update-actions
• update-autoyast-compat
• update-axios
• update-cargo-deps
• update-deps-20250603
• update-deps-20250825
• update-jsdom
• update-networkform-structure
• update-openssl-SLE-16
• update-outdated-pages
• update-shell-quote-dep
• update-spec-files
• update-web-deps-20260302
• update-webpack-dev
• upg-rust-deps
• upgrade_react
• use-full-repo
• user-pw-check
• user_patterns_selection
• user_repo_ay_convert
• users-install-msg
• users_mandatory_step
• users_service
• users_v2_webui
• utoipa_fixes
• v11
• v12
• v13.pre
• v15
• v16
• v17
• v18
• v18.pre
• v19
• v20
• v21
• v22
• v23
• valibot
• validation
• version_18.pre
• vlan_flags
• vlan_support
• vroc-raid-e-drive-undefined
• wait-for-software-set-config
• web-ui-2026
• wip/honyczek/storage-autosizetext
• workaround_empty_proposal
• xtask
• zFCP_refresh
• zFCP_refresh_SLE-16
• zbus-5
• zfcp-dbus-api-v2
• zfcp-manual-activation
• zfcp-ui-api-v2
• zfcp_unattended

Build # 32253615233

Build Type

push

github

Committed by dgdavid

Commit Message

refactor(web): name the dialog action that only closes

Dialogs whose single button just dismisses them read as a confirmation of
nothing, and they had to name the closing callback twice: once for the
dialog, once for the button.

Popup.Close says what the button does and falls back to the dialog's own
onClose, so `onClose={close} actions={<Popup.Close />}` is the whole
wiring. Passing an onClick still works, and is the only option for a
dialog offering no onClose; a Close left with neither reports itself
instead of rendering a button that does nothing.

Coverage Stats

4996 of 6902 branches covered (72.38%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

17298 of 20820 relevant lines covered (83.08%)

135.09 hits per line