agama-project / agama
83%

DEFAULT BRANCH: master
Repo Added
Token 44tiI9bF3ENxJle3CvgstdhpyfGP3kSd5 regen
Build 8775 Last
Files 1046
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 83.121% (-0.1%) from 83.235%
28671708926

push

github

web-flow 
Missing translations (#3688)

## Problem

Some strings are not translated. Missing translatated strings should be
detected by the linter, but there are two edge cases:

* Literal string directly passed as prop to a PF component.
* Literal strings marked for translation with `N_` but then it is not
translated with `_()`.

Examples:
~~~
<PFComponent foo="bar" />

const LABEL = N_("Disk");

<Text>{LABEL}</Text>
~~~

https://bugzilla.suse.com/show_bug.cgi?id=1269514

## Solution

Properly mark the literal strings for translations when they are used in
a prop and fix missing translations in storage UI components by
converting translation-marked constants to type-safe translation
functions.

Changes

* Replaced static translation-marked constants (FILESYSTEM_NAMES,
PARTITIONABLE_SPACE_POLICIES, VOLUME_GROUP_SPACE_POLICIES) with
dedicated translation functions (filesystemLabel,
partitionableSpacePolicyLabel, volumeGroupSpacePolicyLabel).
* Fixed untranslated space policy labels in SpacePolicyMenu and
SpaceActionsTable.
* Removed unused SIZE_UNITS constant.

Moving translation logic into functions ensures translations are always
applied and prevents future instances of forgotten translations.

In network, the connection type labels were not marked for translation.
Fortunatelly, there are already translations for that strings.

4900 of 6833 branches covered (71.71%)

Branch coverage included in aggregate %.

32 of 53 new or added lines in 3 files covered. (60.38%)

39 existing lines in 3 files now uncovered.

25559 of 29811 relevant lines covered (85.74%)

124.08 hits per line

Relevant lines Covered
29811 RELEVANT LINES 25559 COVERED LINES
124.08 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
28671708926 master Missing translations (#3688) ## Problem Some strings are not translated. Missing translatated strings should be detected by the linter, but there are two edge cases: * Literal string directly passed as prop to a PF component. * Literal strings ... push web-flow github
83.12
28671673190 fix-lvm-selector-text fix(web): use correct empty state text Pull #3690 joseivanlopez github
80.01
28670480233 SLE-16 Missing translations (SLE 16 maintenance) (#3689) Fix missing translations in SLE 16.0, see https://bugzilla.suse.com/show_bug.cgi?id=1269514. push web-flow github
64.42
28670442628 fix-missing-translations docs(web): changelog Pull #3688 joseivanlopez github
83.12
28667439712 master feat(web): allow disambiguate form fields accessible name (#3685) ## Motivation As a follow-up to #3684, which this PR actually supersedes, adds a `useFieldLabel` hook that lets any form field adjust its accessible name in a flexible way, reusi... push web-flow github
83.24
28661945828 add-fields-support-for-additonal-label refactor(web): require TranslatedString in SearchableSelectField Type placeholder, emptyPlaceholder and noResultsText as TranslatedString instead of plain string, so untranslated literals are caught at compile time. Plain strings passed as props ... Pull #3685 dgdavid github
83.24
28660366553 add-fields-support-for-additonal-label Merge branch 'master' into add-fields-support-for-additonal-label Pull #3685 web-flow github
83.24
28660366549 add-fields-support-for-additonal-label Merge branch 'master' into add-fields-support-for-additonal-label Pull #3685 web-flow github
83.2
28659467437 fix-missing-translations-sle16 Merge aa240d4a3 into c64f59913 Pull #3689 web-flow github
68.52
28659333428 fix-missing-translations-sle16 Merge 67d0b92c4 into c64f59913 Pull #3689 web-flow github
68.52
See All Builds (6767)

Badge your Repo: agama

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh