agama-project / agama / 29560638065

83%

push

github

Do not set the dns search list for disabled IP protocols (bsc#127481) (#3731)

### Summary

This PR resolves an issue where configuring a connection with disabled
IP protocols failed in NetworkManager if a DNS search list was defined
(`bsc#127481`). Additionally, it corrects a conversion mismatch for
`dnsSearchList` in the AutoYaST network reader.

- SUSE Bugzilla:
[bsc#127481](https://bugzilla.suse.com/show_bug.cgi?id=1271481)


### Problem
1. **NetworkManager Validation Failure:** NetworkManager validates
settings and throws an error if IP-specific attributes (such as
`dns-search`) are present on a protocol whose method is set to
`disabled` (e.g., when disabling IPv6 entirely). The problem is not
limited to what Agama serializes: when updating a connection, Agama
merges its output on top of the connection already stored by
NetworkManager, so contradictory values (e.g. a `dns-search` or
`address-data` left over from a previous `manual` configuration) can be
inherited from the existing connection and re-sent even though the
method is now `disabled`.
2. **AutoYaST Conversion Error:** The AutoYaST parser was translating
the `searchlist` key to snake_case (`dns_searchlist`) instead of the
camelCase (`dnsSearchList`) expected by Agama's connection models,
causing DNS search configurations from profiles to be ignored or
improperly mapped.

### Solution
- **Rust (NetworkManager Client):**
- Added `cleanup_disabled_ip_config` in
`rust/agama-network/src/nm/dbus.rs`, called from
`cleanup_dbus_connection`. When an `ipv4`/`ipv6` section has its method
set to `disabled`, it drops every attribute except `method`. Because
`cleanup_dbus_connection` runs *after* merging with the existing
connection, this also removes contradictory values inherited from it,
not just the ones Agama would serialize.
- This centralizes the "disabled means empty" invariant in a single
place, covering `dns-search` as well as `address-data`, `gateway`,
`dns-data`, routes, etc.
- **Service (... (continued)

4899 of 6836 branches covered (71.66%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

25585 of 29839 relevant lines covered (85.74%)

123.82 hits per line