agama-project / agama / 29493743870

83%

push

github

Do not flood logs with useless errors when downloading default profile fails (#3624)

## Problem

Agama searches for default profiles on each start. Mainly those *.xml
ones wrote useless error / exception reports into logs when not found.

## Solution

The error happened because an internal function for fetching the xml
file returned nil which was not handled anymore. Simply failing doesn't
solve all cases we need - in case of non present default profiles we
want to silently ignore without failing. So, a capability of ignoring
the fail by checking YAST_SKIP_PROFILE_FETCH_ERROR env variable was
added. This variable is set in (almost) all cases when agama-autoyast is
invoked from the code. When this variable is set and no profile is
found, then empty profile is used in subsequent processing to end the
processing pipeline with success.

## Testing

- *Tested manually*


## Screenshots

See the discussion in the bug.

4899 of 6839 branches covered (71.63%)

Branch coverage included in aggregate %.

2 of 6 new or added lines in 2 files covered. (33.33%)

25585 of 29841 relevant lines covered (85.74%)

123.81 hits per line