28005717260
83%

Ran 23 Jun 2026 07:06AM UTC

Jobs 1

Files 65

Run time 1min

Badge

Embed ▾

Committed 19 Jun 2026 12:12PM UTC coverage: 78.07% (-3.3%) from 81.322%

Build # 28005717260

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Skipped messages set last time to now (#8327)

`SkipMsg` and `SkipMsgs` would set the store's `LastTime` to "now", and
this would be stamped into the filestore's block as well. However, a
late replicated stream catchup or a filtered mirror would violate
(_mostly_) monotonic increase of start times, leading to issues when
searching by start time since the filestore's binary search would act on
unordered block timestamps. This PR fixes that by having `SkipMsg(s)`
only carry forward the `LastTime` if already set.

This change has mostly upsides, but one downside is that Interest-based
streams with `noInterest` on a message would not store the message, but
still move both the stream's last sequence AND last timestamp forward
(now it is only the sequence). This is probably fine, but a slight
behavioral change due to the shared code paths. Overall though,
preserving the correct timestamps is more valuable than increasing a
timestamp relating to a message that is not actually stored, especially
since it could otherwise mean wrong messages are delivered.

Coverage Stats

73380 of 93992 relevant lines covered (78.07%)

597493.81 hits per line

Coverage Regressions

Lines	Coverage	∆	File
2391	25.83	-58.53%	src/github.com/nats-io/nats-server/server/mqtt.go
404	73.53	-13.91%	src/github.com/nats-io/nats-server/server/monitor.go
96	56.07	-4.98%	src/github.com/nats-io/nats-server/server/reload.go
64	63.73	-1.04%	src/github.com/nats-io/nats-server/server/opts.go
37	74.19	-0.77%	src/github.com/nats-io/nats-server/server/jetstream_api.go
33	64.3	-2.78%	src/github.com/nats-io/nats-server/server/websocket.go
31	85.68	-2.43%	src/github.com/nats-io/nats-server/server/auth.go
22	84.82	-0.79%	src/github.com/nats-io/nats-server/server/events.go
21	82.6	-0.24%	src/github.com/nats-io/nats-server/server/memstore.go
19	81.19	0.29%	src/github.com/nats-io/nats-server/server/raft.go
18	89.76	-0.37%	src/github.com/nats-io/nats-server/server/client.go
13	86.06	-0.15%	src/github.com/nats-io/nats-server/server/stream.go
10	83.39	0.25%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
10	81.91	-0.95%	src/github.com/nats-io/nats-server/server/parser.go
8	93.41	-0.24%	src/github.com/nats-io/nats-server/server/gateway.go
7	88.51	-0.15%	src/github.com/nats-io/nats-server/server/server.go
6	87.44	0.12%	src/github.com/nats-io/nats-server/server/consumer.go
6	78.94	-0.06%	src/github.com/nats-io/nats-server/server/filestore.go
2	86.73	0.26%	src/github.com/nats-io/nats-server/server/accounts.go
2	90.29	0.25%	src/github.com/nats-io/nats-server/server/leafnode.go
2	70.88	-1.1%	src/github.com/nats-io/nats-server/server/log.go
2	90.83	-0.17%	src/github.com/nats-io/nats-server/server/sublist.go
2	88.11	-0.41%	src/github.com/nats-io/nats-server/server/util.go
1	84.55	-0.05%	src/github.com/nats-io/nats-server/server/jetstream.go
1	97.78	-2.22%	src/github.com/nats-io/nats-server/server/monitor_sort_opts.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	28005717260.1	23 Jun 2026 07:06AM UTC	65	78.07	GitHub Action Run

nats-io / nats-server / 28005717260
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28005717260

nats-io / nats-server / 28005717260 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28005717260

nats-io / nats-server / 28005717260
83%

README BADGES
x