27934019938
77%

Ran 22 Jun 2026 07:35AM UTC

Jobs 1

Files 65

Run time 1min

Badge

Embed ▾

Committed 19 Jun 2026 12:12PM UTC coverage: 81.322% (+1.1%) from 80.262%

Build # 27934019938

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Skipped messages set last time to now (#8327)

`SkipMsg` and `SkipMsgs` would set the store's `LastTime` to "now", and
this would be stamped into the filestore's block as well. However, a
late replicated stream catchup or a filtered mirror would violate
(_mostly_) monotonic increase of start times, leading to issues when
searching by start time since the filestore's binary search would act on
unordered block timestamps. This PR fixes that by having `SkipMsg(s)`
only carry forward the `LastTime` if already set.

This change has mostly upsides, but one downside is that Interest-based
streams with `noInterest` on a message would not store the message, but
still move both the stream's last sequence AND last timestamp forward
(now it is only the sequence). This is probably fine, but a slight
behavioral change due to the shared code paths. Overall though,
preserving the correct timestamps is more valuable than increasing a
timestamp relating to a message that is not actually stored, especially
since it could otherwise mean wrong messages are delivered.

Coverage Stats

76436 of 93992 relevant lines covered (81.32%)

531139.94 hits per line

Coverage Regressions

Lines	Coverage	∆	File
32	83.13	0.15%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
32	80.9	-0.4%	src/github.com/nats-io/nats-server/server/raft.go
27	87.33	-0.27%	src/github.com/nats-io/nats-server/server/consumer.go
21	82.84	0.0%	src/github.com/nats-io/nats-server/server/memstore.go
14	74.95	0.34%	src/github.com/nats-io/nats-server/server/jetstream_api.go
9	64.77	-0.04%	src/github.com/nats-io/nats-server/server/opts.go
7	84.6	-0.28%	src/github.com/nats-io/nats-server/server/jetstream.go
7	90.04	-0.18%	src/github.com/nats-io/nats-server/server/leafnode.go
5	86.47	-0.15%	src/github.com/nats-io/nats-server/server/accounts.go
4	57.11	0.18%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
4	86.21	0.01%	src/github.com/nats-io/nats-server/server/stream.go
3	85.61	0.0%	src/github.com/nats-io/nats-server/server/events.go
3	79.0	0.63%	src/github.com/nats-io/nats-server/server/filestore.go
3	87.44	0.03%	src/github.com/nats-io/nats-server/server/monitor.go
2	72.46	-0.45%	src/github.com/nats-io/nats-server/server/avl/seqset.go
2	90.13	0.1%	src/github.com/nats-io/nats-server/server/client.go
2	91.15	-0.25%	src/github.com/nats-io/nats-server/server/jetstream_batching.go
2	98.58	-1.42%	src/github.com/nats-io/nats-server/server/jetstream_versioning.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	27934019938.1	22 Jun 2026 07:35AM UTC	65	81.32	GitHub Action Run

nats-io / nats-server / 27934019938
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 27934019938

nats-io / nats-server / 27934019938 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 27934019938

nats-io / nats-server / 27934019938
77%

README BADGES
x