nats-io / nats-server
83%

Repo Added 06 May 2019 06:55PM UTC

Files 63

Badge

Embed ▾

LAST BUILD ON BRANCH main
branch: SELECT

CHANGE BRANCH
x

No branch selected

change_nightly_from_main_to_dev

fix_code_coverage

fix_flappers_update_cov_go

main

Committed 05 May 2026 08:44AM UTC coverage: 83.018% (+5.4%) from 77.578%

Build # 25418594118

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Consumer's redelivered state replication and cleanup (#8102)

Several paths left consumer state (`rdc`, `state.Redelivered`,
`state.Pending`, ack floor) drifting from the underlying stream: most
visibly on WorkQueue/Interest with `MaxDeliver`, on single-message
removal, and on purge/compact (including replicated followers).

- Move ack floor if `MaxDeliver` exceeded: without this, the ack floor
stalls behind sequences that exceeded `MaxDeliver`.
- Cleanup redelivery on message delete: `rdc`-only entries (no pending)
for a removed message would otherwise leak forever, and persistent state
on followers would diverge from the leader.
- Cleanup redelivery on stream purge: batch removals (like purge)
bypassed the per-message cleanup path, leaving orphan `rdc` /
`state.Redelivered` entries on every replica.
- `checkRedelivered` only removes below stream's first seq: `rdc` must
outlive `asflr` so `needAck` keeps marking messages past `MaxDeliver`
until the message is removed.
- Cleanup pending on stream purge: leader-side `pending` cleanup wasn't
replicated, so followers' `state.Pending` survived the purge and
diverged.
- Reset `o.rdc` on leader stepdown: followers would preserve stale
`o.rdc`, whereas other state was reset on `o.setLeader(false)`.

Coverage Stats

77212 of 93006 relevant lines covered (83.02%)

508899.9 hits per line

Relevant lines Covered

93006 RELEVANT LINES 77212 COVERED LINES

508899.9 HITS PER LINE

Source Files on main

Recent builds

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
25418594118	main	[FIXED] Consumer's redelivered state replication and cleanup (#8102) Several paths left consumer state (`rdc`, `state.Redelivered`, `state.Pending`, ack floor) drifting from the underlying stream: most visibly on WorkQueue/Interest with `MaxDeliv...	push	06 May 2026 06:48AM UTC	web-flow	github	83.02
25359636143	main	(2.12) [FIXED] Atomic batch: prevent double-pooling of CommittedEntry on cleanup (#8098)	push	05 May 2026 06:37AM UTC	web-flow	github	77.58
25303179738	main	(2.12) [FIXED] Atomic batch: prevent double-pooling of CommittedEntry on cleanup (#8098)	push	04 May 2026 06:52AM UTC	web-flow	github	82.08
25271149988	main	(2.12) [FIXED] Atomic batch: prevent double-pooling of CommittedEntry on cleanup (#8098)	push	03 May 2026 06:48AM UTC	web-flow	github	83.01
25244821959	main	(2.12) [FIXED] Atomic batch: prevent double-pooling of CommittedEntry on cleanup (#8098)	push	02 May 2026 06:36AM UTC	web-flow	github	83.13
25204149721	main	[FIXED] Cluster route compression uses Cluster.MaxPingsOut (#8093) The global `MaxPingsOut` was used, even if `Cluster.MaxPingsOut` was configured to override it.	push	01 May 2026 06:55AM UTC	web-flow	github	83.02
25149500363	main	[IMPROVED] Reduce JS write lock contention on leader changes and Raft group creation (#8087) - `createRaftGroup` no longer holds `js.mu` across filestore/snapshot init and `startRaftNode`; allowing other JS requests to still be serviced without w...	push	30 Apr 2026 06:49AM UTC	web-flow	github	80.64
25092812922	main	Release v2.14.0-RC.3 Signed-off-by: Neil Twigg <neil@nats.io>	push	29 Apr 2026 06:45AM UTC	neilalexander	github	81.82
25036102143	main	Release v2.14.0-RC.2 Signed-off-by: Neil Twigg <neil@nats.io>	push	28 Apr 2026 06:49AM UTC	neilalexander	github	81.99
24978463104	main	(2.14) [ADDED] `RemoteLeafOpts.IgnoreDiscoveredServers` option (#8067) For a given leafnode remote, if this is set to true, this remote will ignore any server leafnode URLs returned by the hub, allowing the user to fully manage the servers this r...	push	27 Apr 2026 06:44AM UTC	web-flow	github	82.03

See All Builds (6123)

nats-io / nats-server
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT

CHANGE BRANCH
x

No branch selected

change_nightly_from_main_to_dev

fix_code_coverage

fix_flappers_update_cov_go

main

CHANGE BRANCH
x

Relevant lines Covered

Source Files on main

Recent builds

nats-io / nats-server 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main branch: SELECT CHANGE BRANCH x No branch selected change_nightly_from_main_to_dev fix_code_coverage fix_flappers_update_cov_go main

CHANGE BRANCH x

Relevant lines Covered

Source Files on main

Recent builds

nats-io / nats-server
83%

README BADGES
x

LAST BUILD ON BRANCH main
branch: SELECT

CHANGE BRANCH
x

No branch selected

change_nightly_from_main_to_dev

fix_code_coverage

fix_flappers_update_cov_go

main

CHANGE BRANCH
x