nats-io / nats-server
81%

DEFAULT BRANCH: main
Repo Added
Files 64
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 80.674% (-0.5%) from 81.166%
26435225498

push

github

web-flow 
Enforce cardinality threshold on `checkSkipFirstBlock` and `checkSkipFirstBlockMulti` (#8227)

At a certain threshold, intersecting the entire stream subject state
becomes considerably more expensive than just walking forward normally,
so we should avoid doing that. In other places in the filestore, we
tweak operations at 1 million subjects, and that seems to roughly align
here too.

Before:
```
goos: darwin
goarch: arm64
pkg: github.com/nats-io/nats-server/v2/server
cpu: Apple M2 Ultra
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1000-24         	    6747	    173332 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/10000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/10000-24        	     735	   1651734 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/100000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/100000-24       	     144	   8261559 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/500000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/500000-24       	      27	  42628478 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1000000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1000000-24      	      13	  87825721 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1500000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/1500000-24      	       8	 135479005 ns/op
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/2000000
BenchmarkFileStoreCheckSkipFirstBlockMultiTippingPoint/UniqueSubjects/2000000-24      	       6	 184404188 ns/op
PASS
ok  	github.com/nats-io/nats-server/v2/server	206.401s
```

After:
```
goos: darwin
goarch: arm64
pkg: ... (continued)

75386 of 93445 relevant lines covered (80.67%)

495966.5 hits per line

Relevant lines Covered
93445 RELEVANT LINES 75386 COVERED LINES
495966.5 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26435225498 main Enforce cardinality threshold on `checkSkipFirstBlock` and `checkSkipFirstBlockMulti` (#8227) At a certain threshold, intersecting the entire stream subject state becomes considerably more expensive than just walking forward normally, so we shoul... push web-flow github
80.67
26386133439 main Enforce cardinality threshold on `checkSkipFirstBlock` and `checkSkipFirstBlockMulti` (#8227) At a certain threshold, intersecting the entire stream subject state becomes considerably more expensive than just walking forward normally, so we shoul... push web-flow github
81.93
26353494176 main Enforce cardinality threshold on `checkSkipFirstBlock` and `checkSkipFirstBlockMulti` (#8227) At a certain threshold, intersecting the entire stream subject state becomes considerably more expensive than just walking forward normally, so we shoul... push web-flow github
83.13
26325003670 main Enforce cardinality threshold on `checkSkipFirstBlock` and `checkSkipFirstBlockMulti` (#8227) At a certain threshold, intersecting the entire stream subject state becomes considerably more expensive than just walking forward normally, so we shoul... push web-flow github
81.81
26271268085 main MQTT: test NATS wildcards in MQTT topics (#8225) Add coverage to show how NATS wildcards characters '*' and '>' are used in MQTT topics. The tests fix the following behavior: 1) MQTT literal topic may become a NATS wildcard subject. For exampl... push web-flow github
81.17
26208478039 main Add a benchmark for WriteTermVote (#8178) A benchmark that measure throughput / latency of WriteTermVote. push web-flow github
78.11
26144494550 main [FIXED] Clean up snapshot file when checkpoint install aborts mid-write (#8202) Remove the snapshot file from a checkpoint on the abort/error paths, so a concurrent `Reset()` doesn't leave old snapshots. Addresses Codex's comment: https://github... push web-flow github
82.18
26079329094 main [IMPROVED] Replace time.After with reusable timer in snapshot and catchup loops (#8186) ## Overview `time.After` creates a new channel and timer that cannot be garbage collected until the timer fires. When used inside a loop, each iteration leak... push web-flow github
77.16
26016392020 main Don't negotiate leafnode compression over WebSockets (#7969) WebSockets already have compression, so this would be wasteful and likely counter-productive to do so twice. Signed-off-by: Neil Twigg <neil@nats.io> push web-flow github
83.06
25982876143 main Don't negotiate leafnode compression over WebSockets (#7969) WebSockets already have compression, so this would be wasteful and likely counter-productive to do so twice. Signed-off-by: Neil Twigg <neil@nats.io> push web-flow github
81.0
See All Builds (6143)