nats-io / nats-server
80%

DEFAULT BRANCH: main
Repo Added
Files 66
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 80.191% (+2.2%) from 78.002%
37729528973

push

github

web-flow 
[FIXED] Leafnode interest and request/reply across account imports (#8730)

Fixes #8733 

A leaf with solicited remotes and no cluster block takes its cluster
name from server_name. The hub tags subscriptions from its links with
that cluster as the origin, and the origin was wrongly applied to
interest and messages that crossed an account import. With one link per
account on the same leaf, a subscriber in an importing account never had
its interest sent to the other account's link, and requests and replies
between the two were dropped as cluster echoes, producing "503 No
Responders".

- Clear the origin on stream import shadow subscriptions in
addShadowSub.
- Drop the leaf origin for messages imported from a service, including
in the route header.
- Let imported messages go back to their origin leaf cluster, which
never saw them in the importing account.

Tests cover interest and request/reply on the same leaf and on another
leaf, request/reply across a hub cluster, stream and service import
loops with a single hub, a named hub cluster and an unnamed hub cluster,
and bridging between two distinct hubs.

Behavior change: a hub without a cluster name advertises an empty name
to its leafs, even when it is clustered, so the leaf can't tell its
connections to that hub apart from connections to other hubs. It
therefore treats an empty name as the same hub. As a result, a client on
a standalone or unnamed hub can no longer reach another account on that
hub through an import that exists only on a leaf. Named hub clusters
already behaved this way. Leafs that connect to two different named hubs
can still bridge them through local imports.

70478 of 87888 relevant lines covered (80.19%)

305056.68 hits per line

Relevant lines Covered
87888 RELEVANT LINES 70478 COVERED LINES
305056.68 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
37729528973 main [FIXED] Leafnode interest and request/reply across account imports (#8730) Fixes #8733 A leaf with solicited remotes and no cluster block takes its cluster name from server_name. The hub tags subscriptions from its links with that cluster as th... push web-flow github
80.19
37573425408 main Add MQTT WebSocket authentication test (#8724) Add a test to check that MQTT uses global or MQTT specific credentials over WebSocket, and ignores WebSocket credentials. push web-flow github
78.0
37415546973 main (2.14) [FIXED] Fast batch ping could start a new batch (#8714) push web-flow github
77.61
37266705808 main [ADDED] TLS for leafnode remote https proxies (#8701) Adds TLS support for leafnode remote proxies using `https://`, configured with an optional `proxy { tls {} }` block (system roots by default). Previously only plain HTTP proxies worked. Also:... push web-flow github
81.17
37182731711 main [ADDED] TLS for leafnode remote https proxies (#8701) Adds TLS support for leafnode remote proxies using `https://`, configured with an optional `proxy { tls {} }` block (system roots by default). Previously only plain HTTP proxies worked. Also:... push web-flow github
80.8
37097747959 main [ADDED] TLS for leafnode remote https proxies (#8701) Adds TLS support for leafnode remote proxies using `https://`, configured with an optional `proxy { tls {} }` block (system roots by default). Previously only plain HTTP proxies worked. Also:... push web-flow github
80.66
36966199994 main [FIXED] Wait for preferred node to become leader during stream restore (#8690) A non-preferred member could win the initial election during clustered stream restore and return a StreamCreateResponse instead of a StreamRestoreResponse, preventing ... push web-flow github
76.65
36816917800 main Improve num pending last block correction (#8681) Wildcard filters couldn't hit the `if len(lbm) == 0 {` case where there was no last block correction needed, which resulted in a cache hit or a loading of the first block regardless when it wasn't... push web-flow github
82.79
36670582312 main [FIXED] MQTT: reload stops QoS 1/2 delivery when max_ack_pending is unset (#8671) Resolves #8661. A reload that treats the `mqtt` options as changed calls `mqttUpdateMaxAckPending`, which assigned the configured `max_ack_pending` to every existi... push web-flow github
82.66
36523289785 main [FIXED] MQTT: reload stops QoS 1/2 delivery when max_ack_pending is unset (#8671) Resolves #8661. A reload that treats the `mqtt` options as changed calls `mqttUpdateMaxAckPending`, which assigned the configured `max_ack_pending` to every existi... push web-flow github
82.74
See All Builds (6270)