28078596732
83%

Ran 24 Jun 2026 07:07AM UTC

Jobs 1

Files 65

Run time 1min

Badge

Embed ▾

Committed 19 Jun 2026 12:12PM UTC coverage: 77.504% (-0.6%) from 78.07%

Build # 28078596732

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Skipped messages set last time to now (#8327)

`SkipMsg` and `SkipMsgs` would set the store's `LastTime` to "now", and
this would be stamped into the filestore's block as well. However, a
late replicated stream catchup or a filtered mirror would violate
(_mostly_) monotonic increase of start times, leading to issues when
searching by start time since the filestore's binary search would act on
unordered block timestamps. This PR fixes that by having `SkipMsg(s)`
only carry forward the `LastTime` if already set.

This change has mostly upsides, but one downside is that Interest-based
streams with `noInterest` on a message would not store the message, but
still move both the stream's last sequence AND last timestamp forward
(now it is only the sequence). This is probably fine, but a slight
behavioral change due to the shared code paths. Overall though,
preserving the correct timestamps is more valuable than increasing a
timestamp relating to a message that is not actually stored, especially
since it could otherwise mean wrong messages are delivered.

Coverage Stats

72848 of 93992 relevant lines covered (77.5%)

492275.73 hits per line

Coverage Regressions

Lines	Coverage	∆	File
218	72.5	-10.1%	src/github.com/nats-io/nats-server/server/memstore.go
84	70.63	-2.9%	src/github.com/nats-io/nats-server/server/monitor.go
57	88.26	-2.03%	src/github.com/nats-io/nats-server/server/leafnode.go
41	6.67	-91.11%	src/github.com/nats-io/nats-server/server/monitor_sort_opts.go
37	83.19	-0.2%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
36	81.22	0.03%	src/github.com/nats-io/nats-server/server/raft.go
33	63.2	-0.53%	src/github.com/nats-io/nats-server/server/opts.go
28	56.59	-14.29%	src/github.com/nats-io/nats-server/server/log.go
26	54.72	-1.35%	src/github.com/nats-io/nats-server/server/reload.go
14	78.81	-0.13%	src/github.com/nats-io/nats-server/server/filestore.go
11	86.47	-0.26%	src/github.com/nats-io/nats-server/server/accounts.go
11	89.91	-0.92%	src/github.com/nats-io/nats-server/server/sublist.go
10	87.35	-0.1%	src/github.com/nats-io/nats-server/server/consumer.go
10	74.24	0.05%	src/github.com/nats-io/nats-server/server/jetstream_api.go
9	72.31	-13.85%	src/github.com/nats-io/nats-server/server/feature_flags.go
8	84.77	-0.05%	src/github.com/nats-io/nats-server/server/events.go
7	89.62	-0.14%	src/github.com/nats-io/nats-server/server/client.go
5	86.04	-0.01%	src/github.com/nats-io/nats-server/server/stream.go
2	93.57	0.16%	src/github.com/nats-io/nats-server/server/gateway.go
2	98.58	-1.42%	src/github.com/nats-io/nats-server/server/jetstream_versioning.go
2	88.67	0.15%	src/github.com/nats-io/nats-server/server/server.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	28078596732.1	24 Jun 2026 07:07AM UTC	65	77.5	GitHub Action Run

nats-io / nats-server / 28078596732
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28078596732

nats-io / nats-server / 28078596732 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28078596732

nats-io / nats-server / 28078596732
83%

README BADGES
x