27895753127
77%

Ran 21 Jun 2026 07:23AM UTC

Jobs 1

Files 65

Run time 1min

Badge

Embed ▾

Committed 19 Jun 2026 12:12PM UTC coverage: 80.262% (+3.0%) from 77.285%

Build # 27895753127

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Skipped messages set last time to now (#8327)

`SkipMsg` and `SkipMsgs` would set the store's `LastTime` to "now", and
this would be stamped into the filestore's block as well. However, a
late replicated stream catchup or a filtered mirror would violate
(_mostly_) monotonic increase of start times, leading to issues when
searching by start time since the filestore's binary search would act on
unordered block timestamps. This PR fixes that by having `SkipMsg(s)`
only carry forward the `LastTime` if already set.

This change has mostly upsides, but one downside is that Interest-based
streams with `noInterest` on a message would not store the message, but
still move both the stream's last sequence AND last timestamp forward
(now it is only the sequence). This is probably fine, but a slight
behavioral change due to the shared code paths. Overall though,
preserving the correct timestamps is more valuable than increasing a
timestamp relating to a message that is not actually stored, especially
since it could otherwise mean wrong messages are delivered.

Coverage Stats

75440 of 93992 relevant lines covered (80.26%)

517863.73 hits per line

Coverage Regressions

Lines	Coverage	∆	File
64	82.98	-0.38%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
23	74.61	-0.13%	src/github.com/nats-io/nats-server/server/jetstream_api.go
17	87.6	-0.23%	src/github.com/nats-io/nats-server/server/consumer.go
16	81.3	0.61%	src/github.com/nats-io/nats-server/server/raft.go
12	86.19	0.0%	src/github.com/nats-io/nats-server/server/stream.go
11	86.61	-0.23%	src/github.com/nats-io/nats-server/server/accounts.go
11	85.61	0.56%	src/github.com/nats-io/nats-server/server/events.go
7	56.92	-0.18%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
7	64.81	1.53%	src/github.com/nats-io/nats-server/server/opts.go
6	78.37	-0.04%	src/github.com/nats-io/nats-server/server/filestore.go
2	90.03	0.86%	src/github.com/nats-io/nats-server/server/client.go
2	93.49	0.12%	src/github.com/nats-io/nats-server/server/gateway.go
2	90.22	4.45%	src/github.com/nats-io/nats-server/server/leafnode.go
1	87.7	-0.41%	src/github.com/nats-io/nats-server/server/util.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	27895753127.1	21 Jun 2026 07:23AM UTC	65	80.26	GitHub Action Run

nats-io / nats-server / 27895753127
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 27895753127

nats-io / nats-server / 27895753127 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 27895753127

nats-io / nats-server / 27895753127
77%

README BADGES
x