27862350863
77%

Ran 20 Jun 2026 07:09AM UTC

Jobs 1

Files 65

Run time 1min

Badge

Embed ▾

Committed 19 Jun 2026 12:12PM UTC coverage: 77.285% (-0.4%) from 77.685%

Build # 27862350863

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Skipped messages set last time to now (#8327)

`SkipMsg` and `SkipMsgs` would set the store's `LastTime` to "now", and
this would be stamped into the filestore's block as well. However, a
late replicated stream catchup or a filtered mirror would violate
(_mostly_) monotonic increase of start times, leading to issues when
searching by start time since the filestore's binary search would act on
unordered block timestamps. This PR fixes that by having `SkipMsg(s)`
only carry forward the `LastTime` if already set.

This change has mostly upsides, but one downside is that Interest-based
streams with `noInterest` on a message would not store the message, but
still move both the stream's last sequence AND last timestamp forward
(now it is only the sequence). This is probably fine, but a slight
behavioral change due to the shared code paths. Overall though,
preserving the correct timestamps is more valuable than increasing a
timestamp relating to a message that is not actually stored, especially
since it could otherwise mean wrong messages are delivered.

Coverage Stats

72642 of 93992 relevant lines covered (77.29%)

592121.48 hits per line

Coverage Regressions

Lines	Coverage	∆	File
1099	78.4	0.12%	src/github.com/nats-io/nats-server/server/filestore.go
348	72.45	-3.82%	src/github.com/nats-io/nats-server/server/memstore.go
127	85.77	-4.52%	src/github.com/nats-io/nats-server/server/leafnode.go
68	86.41	-2.11%	src/github.com/nats-io/nats-server/server/server.go
59	80.69	-0.61%	src/github.com/nats-io/nats-server/server/raft.go
41	53.94	-2.13%	src/github.com/nats-io/nats-server/server/reload.go
34	89.17	-0.64%	src/github.com/nats-io/nats-server/server/client.go
28	56.59	-14.29%	src/github.com/nats-io/nats-server/server/log.go
23	63.28	-0.33%	src/github.com/nats-io/nats-server/server/opts.go
20	83.36	0.19%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
19	80.95	0.0%	src/github.com/nats-io/nats-server/server/store.go
14	74.74	0.4%	src/github.com/nats-io/nats-server/server/jetstream_api.go
14	89.66	-1.17%	src/github.com/nats-io/nats-server/server/sublist.go
11	63.38	-0.93%	src/github.com/nats-io/nats-server/server/websocket.go
10	82.55	-0.4%	src/github.com/nats-io/nats-server/server/route.go
8	85.05	-0.63%	src/github.com/nats-io/nats-server/server/auth.go
8	87.83	0.51%	src/github.com/nats-io/nats-server/server/consumer.go
6	70.43	-0.21%	src/github.com/nats-io/nats-server/server/monitor.go
5	85.05	0.28%	src/github.com/nats-io/nats-server/server/events.go
5	93.37	-0.12%	src/github.com/nats-io/nats-server/server/gateway.go
5	84.64	-0.14%	src/github.com/nats-io/nats-server/server/jetstream.go
4	81.53	-0.38%	src/github.com/nats-io/nats-server/server/parser.go
4	86.19	0.13%	src/github.com/nats-io/nats-server/server/stream.go
2	98.58	-1.42%	src/github.com/nats-io/nats-server/server/jetstream_versioning.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	27862350863.1	20 Jun 2026 07:09AM UTC	65	77.29	GitHub Action Run

nats-io / nats-server / 27862350863
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 27862350863

nats-io / nats-server / 27862350863 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 27862350863

nats-io / nats-server / 27862350863
77%

README BADGES
x