IJHack / QtPass / 27732603053

55%

Build Type

push

github

Committed by web-flow

Commit Message

fix: code quality audit for imitatepass.cpp and mainwindow.cpp (#1571)

* fix: code quality audit for imitatepass.cpp and mainwindow.cpp (#1508)

- mainwindow: guard setFilterRegularExpression with regExp.isValid() check
- mainwindow: use Qt::SingleShotConnection (Qt6) / manual disconnect (Qt5)
  for the finishedShow→passwordFromFileToClipboard connection to prevent
  accumulation across multiple copyPasswordFromTreeview calls
- mainwindow: remove dead null-check after 'new TrayIcon(this)' (operator
  new throws, never returns nullptr)
- imitatepass: update currentDir at end of the per-directory block in
  reencryptPath so the directory-change guard actually fires on transitions
- imitatepass: promote static QString transactionOutput to a member variable
  (m_transactionOutput) eliminating function-static lifetime and state leakage
- imitatepass: delete dead removeDir() implementation and its declaration;
  remove corresponding imitatePassRemoveDir unit test
- imitatepass: extract translatePathForWsl() private helper shared by
  pgit() and pgpg() to eliminate the duplicated wslpath invocation body

Fix 8 (lift QMessageBox out of StoreModel) was skipped: executeDropAction
returns bool synchronously from a dropMimeData override; introducing an
async signal/out-parameter confirmation would require a full architectural
change incompatible with Qt's drop protocol.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* style: clang-format tst_util.cpp

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

9 of 12 new or added lines in 2 files covered. (75.0%)

4 existing lines in 1 file now uncovered.

3676 of 6672 relevant lines covered (55.1%)

29.39 hits per line