IJHack / QtPass / 27732132900

55%

push

github

fix: P1 audit findings — executor crash, storemodel guard, getKeysFromFile, sort order, reencryptPath init (#1570)

* fix: P1 audit findings — executor crash emit, storemodel guard, getKeysFromFile, sort order, reencryptPath init (#1508)

- executor: emit error() on CrashExit instead of silently swallowing it
- storemodel: guard indexes.at(0) against empty list in mimeData()
- imitatepass: bail getKeysFromFile on any non-zero GPG exit (not just when both outputs empty)
- configdialog: sort profile rows descending before deletion (comment said big-to-small, code sorted ascending)
- passbackendfactory: call init() in getImitatePass() so ImitatePass has valid settings when used in RealPass mode for reencryptPath

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: use transparent std::greater<> functor (clang-tidy modernize)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: address review findings on P1 fixes

- storemodel: return nullptr (not new QMimeData) for empty index list — matches Qt mimeData() contract
- executor: read stderr on exitCode!=0 in crash branch, matching NormalExit behaviour

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: connect Executor::error to Pass::finished so crash exits are handled

The error() signal was emitted on CrashExit but had no receivers in Pass,
leaving callers in a permanent "working" state. Route it through the same
Pass::finished slot as normal exits so the transaction chain completes.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

11 of 13 new or added lines in 6 files covered. (84.62%)

3681 of 6683 relevant lines covered (55.08%)

29.35 hits per line