IJHack / QtPass / 27733263679

55%

push

github

fix(#1508): audit quality sweep — path sep, null-check, timeout, docs, tests (#1572)

* fix(#1508): audit quality sweep — path sep, null-check, timeout, docs, tests

- util.cpp: normalizeFolderPath no longer uses QDir::separator() or
  QDir::toNativeSeparators(); always appends '/' (Qt internal convention)
- configdialog.cpp validate(): null-check QTableWidgetItem before
  dereferencing to prevent crash on cells never explicitly set
- configdialog.cpp isQrencodeAvailable(): add 2 s timeout to
  waitForFinished() to prevent hanging on stalled network filesystems
- pass.h setEnvVar(): expand doc-block to make the trailing-'=' contract
  explicit so callers cannot misread it as accepting a bare name
- tests/auto/util/tst_util.cpp: update existing normalizeFolderPath tests
  to match the new forward-slash contract; add normalizeFolder() covering
  idempotency, append, empty-string and backslash-terminated inputs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: kill qrencode process on waitForFinished timeout

If `which qrencode` takes >2 s the timed-out process was left running and
partial/empty output was stored as the executable path. Kill and return false.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

4 of 8 new or added lines in 2 files covered. (50.0%)

3675 of 6675 relevant lines covered (55.06%)

29.36 hits per line