IJHack / QtPass / 27720487634
55%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 80
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 55.213% (-0.8%) from 56.049%
27720487634

push

github

web-flow 
refactor(#1511): delete 37 dead setter/getter wrappers (#1563)

* refactor(#1511): delete 37 dead setter/getter wrappers (#1563)

ConfigDialog saves settings exclusively via `QtPassSettings::save(AppSettings)`,
making direct individual setter calls production-dead.  Convert all test
callers to the `load → modify field → save` pattern, then remove the
one-line wrapper boilerplate.

Deleted wrappers:
- bool setters: setClipBoardType, setUseSelection, setUseAutoclear,
  setUseAutoclearPanel, setHidePassword, setHideContent, setUseMonospace,
  setDisplayAsIs, setNoLineWrapping, setAddGPGId, setUseGit, setUseGrepSearch,
  setUseOtp, setUseQrencode, setUseTrayIcon, setHideOnClose, setStartMinimized,
  setAlwaysOnTop, setAutoPull, setAutoPush, setUseTemplate, setTemplateAllFields,
  setUseWebDav, setAvoidCapitals, setAvoidNumbers, setLessRandom, setUseSymbols,
  setShowProcessOutput, setUseAutoclearPanel
- string setters: setWebDavUrl, setWebDavUser, setWebDavPassword,
  setSshAuthSockOverride
- password-config setters: setPasswordConfiguration, setPasswordLength,
  setPasswordCharsSelection, setPasswordChars
- dead getter: getSshAuthSockOverride (missed in PR J), getGpgHome

Replace the remaining test usages — BoolSetting/StringSetting struct
setter-pointers, SettingGuard destructors, and direct calls in
tst_passwordconfig, tst_mainwindow, tst_integration — with the same
AppSettings write path used by production code.

Also fix a pre-existing test-isolation bug: setAndGetPasswordLength and
setAndGetPasswordConfiguration now restore the password configuration after
each test, and initTestCase resets it to structural defaults to guard against
settings leaking between non-portable (non-isolated) test runs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(tests): tighten test isolation for passwordConfiguration mutations

Four issues found during review of the dead-setter PR (1563):

1. initTestCase reordering: backup the settings file BEFORE r... (continued)

3702 of 6705 relevant lines covered (55.21%)

28.34 hits per line

Coverage Regressions

Lines Coverage ∆ File
13
85.9
 -4.52% src/qtpasssettings.cpp
Jobs
ID Job ID Ran Files Coverage
1 27720487634.1 80
55.21
 GitHub Action Run
Source Files on build 27720487634