IJHack / QtPass / 27717964794

55%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(#1511): delete 30 dead getter wrappers from QtPassSettings (#1562)

* refactor(#1511): delete 30 dead getter wrappers from QtPassSettings (#1562)

Replace getter function-pointers in tst_settings with pointer-to-data-member
(`bool/int/QString AppSettings::*field`) so round-trip tests use
`QtPassSettings::load().*s.field` instead of calling the getter directly.
This makes 30 bool/int/string/enum getters dead; delete them from both the
header declaration and the .cpp implementation.

Also refactors `initExecutables()` to use an AppSettings snapshot (4-field
multi-read site), replacing the now-deleted `getGitExecutable()` and
`getGpgExecutable()` calls there and in two test helpers.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: address PR review findings for refactor/delete-dead-getters

- Manually wrap 6 boolSettings/stringSettings entries that exceed 80 chars
  (clang-format version skew between local v19 and CI); CI enforces wrapping
- Consolidate double QtPassSettings::load() in tst_mainwindow initTestCase()
  into a single snapshot (reads usePass and gpgExecutable)
- Restore "got %3" in boolRoundTrip QVERIFY2 message for clearer failure output

Skipped: gpg→gpg2 fallback (original code had none; YAGNI), std::array
modernize suggestion (scope creep), QCOMPARE→QVERIFY2 (QCOMPARE already
prints both values on failure, so QVERIFY2 would be inferior here).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

9 of 9 new or added lines in 1 file covered. (100.0%)

20 existing lines in 1 file now uncovered.

3827 of 6828 relevant lines covered (56.05%)

24.6 hits per line