IJHack / QtPass / 27699675724

55%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(#1511): inject Pass* into StoreModel; inject gpgExe into KeygenDialog (#1557)

* refactor(#1511): inject Pass* into StoreModel; inject gpgExe into KeygenDialog

StoreModel:
- Add Pass *m_pass member and setPass(Pass*) method; remove
  qtpasssettings.h dependency from storemodel.cpp
- executeDropAction: use store member instead of QtPassSettings::getPassStore()
- performDrop: de-static, guard on m_pass, use m_pass->Move/Copy instead of
  QtPassSettings::getPass()->Move/Copy
- MainWindow wires proxyModel.setPass(QtPassSettings::getPass()) at init

KeygenDialog:
- Constructor gains explicit QString &gpgExe parameter (mirrors ImportKeyDialog)
- m_gpgExe stored and passed to Pass::getDefaultKeyTemplate instead of
  QtPassSettings::getGpgExecutable()
- configdialog.cpp callers updated: on_pushButtonGenerateKey_clicked passes
  ui->gpgPath->text(); wizard() passes local gpg variable already in scope

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(#1557): rebind StoreModel backend after settings save; drop stale m_gpgExe member

- mainwindow.cpp config(): after accepting config dialog, call
  proxyModel.setPass(activePass) alongside the existing updateEnv() so
  StoreModel::m_pass tracks the correct backend when usePass mode
  toggles (PassBackendFactory::invalidate resets the cached pointer and
  getPass() may return the other backend on next call)
- keygendialog.h/cpp: drop m_gpgExe member; gpgExe is used only once
  (Pass::getDefaultKeyTemplate) in the constructor body so storing it
  for the dialog's lifetime is unnecessary — pass the parameter directly

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

5 of 14 new or added lines in 4 files covered. (35.71%)

1 existing line in 1 file now uncovered.

3963 of 6940 relevant lines covered (57.1%)

23.25 hits per line