IJHack / QtPass / 27697884856

55%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(#1511): wire passStore into static chain; parameterise Util::configIsValid/getDir (#1555)

* refactor(#1511): wire passStore into static chain; parameterise Util::configIsValid/getDir

- Pass::getGpgIdPath/getRecipientList/getRecipientString now take an
  explicit passStore parameter; removes qtpasssettings.h from pass.cpp
- Util::configIsValid(const AppSettings &) and getDir(..., passStore)
  parameterised; removes qtpasssettings.h from util.cpp
- imitatepass.cpp uses m_settings.passStore at all 4 call sites
- mainwindow.cpp, configdialog.cpp, qtpass.cpp, usersdialog.cpp updated
  at all affected call sites
- tst_util.cpp: PassStoreGuard+setPassStore boilerplate removed from
  static-chain tests; passStore passed directly; configIsValid/getDir
  calls updated with explicit AppSettings / passStore args

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(#1555): normalise fallback path, guard root store, update stale doc examples

- pass.cpp getGpgIdPath: use normalizedStore (not raw passStore) in the
  !found fallback so both branches always return a forward-slash path;
  guard the startsWith boundary check against root-store ("/") causing a
  "//" prefix by only appending "/" when cleanPassStore doesn't already
  end with one
- util.cpp: update @example and @param blocks for configIsValid and
  getDir to match their current signatures (AppSettings + passStore args)
- tst_util.cpp getGpgIdPathSubfolder: apply QDir::cleanPath to both
  sides of the comparison for cross-platform path separator consistency

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* style: clang-format mainwindow.cpp, pass.h, usersdialog.cpp, util.h

Reflow long Util::getDir / Pass::getRecipientString / getGpgIdPath call
sites that exceeded the 80-column limit after the passStore parameter was
added in the previous commit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

23 of 62 new or added lines in 7 files covered. (37.1%)

14 existing lines in 2 files now uncovered.

3963 of 6937 relevant lines covered (57.13%)

23.21 hits per line