IJHack / QtPass / 27701586242

55%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(#1511): inject Pass*/AppSettings into UsersDialog (#1558)

* refactor(#1511): inject Pass*/AppSettings into UsersDialog

Constructor gains Pass *pass and const AppSettings &s parameters,
mirroring the pattern established for ImportKeyDialog and PasswordDialog.
Stored as m_pass, m_passStore, m_gpgExe; replaces 8 QtPassSettings
singleton reads:

- loadGpgKeys: getPass()->listKeys() → m_pass->listKeys()
- markSecretKeys: getPass()->listKeys("",true) → m_pass->listKeys
- loadRecipients: getPass()->listKeys (×2) + getPassStore (×2) → members
- accept: getPass()->Init → m_pass->Init
- on_importKeyButton_clicked: getGpgExecutable() → m_gpgExe

Callers updated:
- MainWindow::onUsers / addRecipient: pass QtPassSettings::getPass() +
  QtPassSettings::load()
- ConfigDialog wizard: same — load() returns the temporarily-switched
  passStore already set by setPassStore(cleanPath) on line 784

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(#1558): assert pass != nullptr in UsersDialog constructor

Q_ASSERT(pass) fires in debug builds if a null backend is injected,
making the precondition explicit with zero cost in release builds.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

0 of 16 new or added lines in 3 files covered. (0.0%)

1 existing line in 1 file now uncovered.

3963 of 6942 relevant lines covered (57.09%)

23.24 hits per line